Skip to content

Use module-info instead of manifest #1287

@kermandev

Description

@kermandev

Currently adventure does not declare a module-info and relies on the Automatic-Module-Name, this is bad for people wanting to add adventure as a transitive dependency in their modules as javac will warn about this behavior and provides other problems. As without module info's you are required to requires every path used, instead of its known as a transitive dependency as an API through the base adventure package.

Currently required: (not exhaustive)

module example {
    requires net.kyori.adventure;
    requires net.kyori.adventure.key;
    requires net.kyori.examination.api;
    requires net.kyori.examination.string;
}

Expected:

module example {
    requires net.kyori.adventure; // Or with transitive for platform implementations.
}

Metadata

Metadata

Assignees

No one assigned

    Type

    No type

    Projects

    No projects

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions