ClickEvent.custom crashes MiniMessage.serialize

[kangarko]

Creating a new click event with a custom tag will crash MiniMessage.serialize

Code

ClickEvent.custom(Key.key("fo_custom_command"), BinaryTagHolder.binaryTagHolder(CommonCore.GSON.toJson(CommonCore.newHashMap("command", text))))

Error

java.lang.IllegalStateException: Payload is not a string payload, is CustomImpl{key=KeyImpl{namespace="minecraft", value="fo_custom_command"}, nbt=BinaryTagHolderImpl{}}
	at net.kyori.adventure.text.event.ClickEvent.value(ClickEvent.java:286) ~[adventure-api-4.24.0.jar:?]
	at net.kyori.adventure.text.minimessage.tag.standard.ClickTag.lambda$static$0(ClickTag.java:52) ~[adventure-text-minimessage-4.24.0.jar:?]
	at net.kyori.adventure.text.minimessage.internal.serializer.StyleClaimImpl.lambda$apply$0(StyleClaimImpl.java:57) ~[adventure-text-minimessage-4.24.0.jar:?]
	at net.kyori.adventure.text.minimessage.MiniMessageSerializer$Collector.style(MiniMessageSerializer.java:320) ~[adventure-text-minimessage-4.24.0.jar:?]
	at net.kyori.adventure.text.minimessage.internal.serializer.SerializableResolver$Single.handle(SerializableResolver.java:132) ~[adventure-text-minimessage-4.24.0.jar:?]
	at net.kyori.adventure.text.minimessage.tag.resolver.SequentialTagResolver.handle(SequentialTagResolver.java:89) ~[adventure-text-minimessage-4.24.0.jar:?]
	at net.kyori.adventure.text.minimessage.MiniMessageSerializer.visit(MiniMessageSerializer.java:70) ~[adventure-text-minimessage-4.24.0.jar:?]
	at net.kyori.adventure.text.minimessage.MiniMessageSerializer.serialize(MiniMessageSerializer.java:57) ~[adventure-text-minimessage-4.24.0.jar:?]
	at net.kyori.adventure.text.minimessage.MiniMessageImpl.serialize(MiniMessageImpl.java:122) ~[adventure-text-minimessage-4.24.0.jar:?]
	at net.kyori.adventure.text.minimessage.MiniMessageImpl.serialize(MiniMessageImpl.java:46) ~[adventure-text-minimessage-4.24.0.jar:?]

Please advise how can I serialize these components as we need to convert them to json etc. and back and for our chat plugin.

Thanks,
Matej

@devpedrobarbosa

[kezz]

Custom click events are not yet supported in MiniMessage.

[devpedrobarbosa]

@kezz

Thanks for the clarification.

[kangarko]

@kezz so it's not planned at all or not planned yet?

[Strokkur424]

It's incredibly low priority considering the fact that MiniMessage is primarily supposed to be a format for easily writing chat components. I doubt there are many people who sit down and think "I need to have NBT payload in my click events". (It does have a use case, yes, but for most simple stuff, people would just make their own little wrapper tag resolver and only ever deserialize from MiniMessage).

I don't think anybody here is directly opposed to having SNBT payload custom click events in the click tag, but somebody would just have to come around to doing it. Feel free to open up a PR, but I almost feel like this is best done after named arguments are merged so that the syntax doesn't get all confused.

[kangarko]

I understand that; we use minimessage to serialize components into a readable format which we can save and read from a file and let plugin users customize it easier than having to deal with native JSON. If this could get implemented it would be awesome, if not I guess the only way to do this is via JSON.

[kangarko]

And thanks for the clarification btw!

[kezz]

@kezz so it's not planned at all or not planned yet?

It will be added in Adventure 5.0.

[kezz]

Fixed in 5.0.0.

[kangarko]

Amazing TYSM!