Merge pull request #220 from Doc94/feature/improvement-paper-archive-version-check

feat: improve version comparison for Paper

Author: electronicboy

src/utils/github.ts

@@ -52,12 +52,24 @@ export const getProjectRepository = (project: string, version: string): string =
   if (project !== "paper") return `https://github.com/PaperMC/${project}`;
   if (project === "paper" && version === "1.7.10") return "https://github.com/PaperMC/Paper-1.7";
 
-  const baseVersion = [21, 4]; // 1.21.4 is after the hardfork
-  const isBelowBaseVersion = version
-    .replace(/^1\./, "")
-    .split(".")
-    .map(Number)
-    .some((v, i) => v < (baseVersion[i] || 0));
-
-  return isBelowBaseVersion ? "https://github.com/PaperMC/Paper-Archive" : "https://github.com/PaperMC/Paper";
+  const baseVersion = "1.21.4"; // after the hardfork
+
+  return isVersionBelow(version, baseVersion) ? "https://github.com/PaperMC/Paper-Archive" : "https://github.com/PaperMC/Paper";
 };
+
+function isVersionBelow(version: string, base: string): boolean {
+  const v = version.split(".").map(Number);
+  const b = base.split(".").map(Number);
+
+  const len = Math.max(v.length, b.length);
+
+  for (let i = 0; i < len; i++) {
+    const vi = v[i] ?? 0;
+    const bi = b[i] ?? 0;
+
+    if (vi < bi) return true;
+    if (vi > bi) return false;
+  }
+
+  return false;
+}