fix: disconnectSocket requires socketId variable

Signed-off-by: Matt Krick <[email protected]>

Author: mattkrick

Diff for: packages/server/graphql/private/mutations/disconnectSocket.ts

@@ -8,14 +8,11 @@ import {MutationResolvers} from '../resolverTypes'
 
 const disconnectSocket: MutationResolvers['disconnectSocket'] = async (
   _source,
-  {userId},
-  {dataLoader, socketId}
+  {userId, socketId},
+  {dataLoader}
 ) => {
   const redis = getRedis()
 
-  // AUTH
-  if (!socketId) return null
-
   // RESOLUTION
   const [user, userPresence] = await Promise.all([
     dataLoader.get('users').load(userId),

Diff for: packages/server/graphql/private/typeDefs/Mutation.graphql

@@ -149,6 +149,10 @@ type Mutation {
     the userId to disconnect
     """
     userId: ID!
+    """
+    the socketId of the user that disconnected
+    """
+    socketId: ID!
   ): DisconnectSocketPayload
 
   """

Diff for: packages/server/utils/serverHealthChecker.ts

@@ -71,7 +71,7 @@ class ServerHealthChecker {
             if (socketServers.includes(socketInstanceId)) return
             // let GQL handle the disconnect logic so it can do special handling like notify team memers
             Logger.log(`serverHealthChecker: ${socketId} is on dead instace ${socketInstanceId}`)
-            await callGQL(disconnectQuery, {userId})
+            await callGQL(disconnectQuery, {userId, socketId})
           })
         })
       )

Diff for: packages/server/wsHandler.ts

@@ -49,8 +49,8 @@ mutation ConnectSocket($socketInstanceId: ID!) {
 }`
 
 export const disconnectQuery = `
-mutation DisconnectSocket($userId: ID!) {
-  disconnectSocket(userId: $userId) {
+mutation DisconnectSocket($userId: ID!, $socketId: ID!) {
+  disconnectSocket(userId: $userId, socketId: $socketId) {
     user {
       id
     }
@@ -212,7 +212,7 @@ export const wsHandler = makeBehavior<{token?: string}>({
     const dataLoader = getNewDataLoader()
     await execute({
       document: parse(disconnectQuery),
-      variableValues: {userId},
+      variableValues: {userId, socketId},
       schema: privateSchema,
       contextValue: {dataLoader, ip: extra.ip, authToken, socketId}
     })