fix: return 404 if PWAHandler cannot find files

Dschoordsch · Dschoordsch · commit 93bbdc83ac64 · 2025-03-21T15:01:00.000+01:00
This is better than crashing through a C++ assertion.
diff --git a/packages/server/PWAHandler.ts b/packages/server/PWAHandler.ts
@@ -3,6 +3,8 @@ import acceptsBrotli from './acceptsBrotli'
 import serveStatic from './utils/serveStatic'
 
 const PWAHandler = (res: HttpResponse, req: HttpRequest) => {
-  serveStatic(res, req.getUrl().slice(1), acceptsBrotli(req))
+  if (!serveStatic(res, req.getUrl().slice(1), acceptsBrotli(req))) {
+    res.writeStatus('404').end()
+  }
 }
 export default PWAHandler

Original file line number	Diff line number	Diff line change
`@@ -3,6 +3,8 @@ import acceptsBrotli from './acceptsBrotli'`
`3`	`3`	`import serveStatic from './utils/serveStatic'`
`4`	`4`
`5`	`5`	`const PWAHandler = (res: HttpResponse, req: HttpRequest) => {`
`6`		`- serveStatic(res, req.getUrl().slice(1), acceptsBrotli(req))`
	`6`	`+ if (!serveStatic(res, req.getUrl().slice(1), acceptsBrotli(req))) {`
	`7`	`+ res.writeStatus('404').end()`
	`8`	`+ }`
`7`	`9`	`}`
`8`	`10`	`export default PWAHandler`