fix: ditch cheerio and undici (#12040)

Author: Dschoordsch

packages/server/package.json

@@ -23,7 +23,6 @@
     "@amplitude/analytics-types": "^1.3.2",
     "@types/analytics-node": "^3.1.3",
     "@types/bcryptjs": "^2.4.2",
-    "@types/cheerio": "^0.22.30",
     "@types/dotenv": "^6.1.1",
     "@types/faker": "^5.5.9",
     "@types/jsdom": "^21.1.7",
@@ -76,7 +75,6 @@
     "adaptivecards": "2.10.0",
     "axios": "^1.8.4",
     "bcryptjs": "^2.4.3",
-    "cheerio": "1.0.0",
     "cron": "^4.3.0",
     "dataloader": "^2.0.0",
     "dayjs": "^1.11.13",
@@ -105,6 +103,7 @@
     "nest-graphql-endpoint": "^0.8.3",
     "node-env-flag": "0.1.0",
     "node-html-markdown-cloudflare": "^1.3.0",
+    "node-html-parser": "^7.0.1",
     "nodemailer": "^6.9.9",
     "oauth-1.0a": "^2.2.6",
     "object-hash": "^3.0.0",

packages/server/utils/atlassian/jiraImages.ts

@@ -1,7 +1,7 @@
 import base64url from 'base64url'
-import * as cheerio from 'cheerio'
 import crypto from 'crypto'
 import ms from 'ms'
+import {parse} from 'node-html-parser'
 import type AtlassianServerManager from '../AtlassianServerManager'
 import getRedis from '../getRedis'
 
@@ -24,21 +24,20 @@ export const updateJiraImageUrls = (cloudId: string, descriptionHTML: string) =>
   const imageUrlToHash = {} as Record<string, string>
   const projectBaseUrl = `https://api.atlassian.com/ex/jira/${cloudId}`
   if (!descriptionHTML) return {updatedDescription: descriptionHTML, imageUrlToHash}
-  const $ = cheerio.load(descriptionHTML)
-  $('body')
-    .find('img')
-    .each((_i, img) => {
-      const imageUrl = $(img).attr('src')
-      if (!imageUrl) return
 
-      const absoluteImageUrl = `${projectBaseUrl}${imageUrl}`
-      const hashedImageUrl = createImageUrlHash(absoluteImageUrl)
-      imageUrlToHash[absoluteImageUrl] = hashedImageUrl
+  const root = parse(descriptionHTML)
+  const imgTags = root.getElementsByTagName('img')
+  imgTags.forEach((img) => {
+    const imageUrl = img.getAttribute('src')
+    if (!imageUrl) return
 
-      $(img).attr('src', createParabolImageUrl(hashedImageUrl))
-    })
+    const absoluteImageUrl = `${projectBaseUrl}${imageUrl}`
+    const hashedImageUrl = createImageUrlHash(absoluteImageUrl)
+    imageUrlToHash[absoluteImageUrl] = hashedImageUrl
 
-  return {updatedDescription: $.html(), imageUrlToHash}
+    img.setAttribute('src', createParabolImageUrl(hashedImageUrl))
+  })
+  return {updatedDescription: root.toString(), imageUrlToHash}
 }
 
 export const downloadAndCacheImages = async (