deprecate configure option --disable-file-sync

Author: wkliao

configure.ac

@@ -130,7 +130,6 @@ AH_TEMPLATE([NF_INT8_IS_C_],            [C type for Fortran INT8])
 AH_TEMPLATE([NF_INT8_T],                [Type for Fortran INT8])
 AH_TEMPLATE([NF_REAL_IS_C_],            [C type for Fortran REAL])
 AH_TEMPLATE([NO_IEEE_FLOAT],            [Does system have IEEE FLOAT])
-AH_TEMPLATE([DISABLE_FILE_SYNC],        [Define if to disable MPI_File_sync])
 dnl AH_TEMPLATE([ENABLE_IN_PLACE_SWAP], [Define if to enable in-place byte swap])
 dnl AH_TEMPLATE([DISABLE_IN_PLACE_SWAP],[Define if to disable in-place byte swap])
 AH_TEMPLATE([ENABLE_SUBFILING],         [Define if to enable subfiling feature])
@@ -2221,16 +2220,6 @@ AC_SUBST(LATEX)
 AC_SUBST(DVIPDF)
 AM_CONDITIONAL([HAS_LATEX], [test "x$has_latex" = xyes])
 
-AC_ARG_ENABLE([file-sync],
-    [AS_HELP_STRING([--disable-file-sync],
-                    [Disable MPI file sync if you know your file system can
-                     provide data consistency. @<:@default: enabled@:>@])],
-    [file_sync=${enableval}], [file_sync=yes]
-)
-if test "x${file_sync}" = xno ; then
-    AC_DEFINE(DISABLE_FILE_SYNC)
-fi
-
 AC_ARG_ENABLE([large-single-req],
     [AS_HELP_STRING([--enable-large-single-req],
                     [Enable large (> 2 GiB) single request in individual MPI-IO

src/drivers/ncmpio/ncmpio_sync.c

@@ -33,7 +33,6 @@
  */
 int
 ncmpio_file_sync(NC *ncp) {
-#ifndef DISABLE_FILE_SYNC
     int mpireturn;
 
     if (ncp->independent_fh != MPI_FILE_NULL) {
@@ -49,7 +48,7 @@ ncmpio_file_sync(NC *ncp) {
         return ncmpii_error_mpi2nc(mpireturn, "MPI_File_sync");
 
     TRACE_COMM(MPI_Barrier)(ncp->comm);
-#endif
+
     return NC_NOERR;
 }
 
@@ -205,24 +204,6 @@ ncmpio_sync_numrecs(void *ncdp)
     /* clear numrecs dirty bit */
     fClr(ncp->flags, NC_NDIRTY);
 
-#ifndef DISABLE_FILE_SYNC
-    if (NC_doFsync(ncp)) { /* NC_SHARE is set */
-        int mpierr, mpireturn;
-        if (NC_indep(ncp)) {
-            TRACE_IO(MPI_File_sync)(ncp->independent_fh);
-        }
-        else {
-            TRACE_IO(MPI_File_sync)(ncp->collective_fh);
-        }
-        if (mpireturn != MPI_SUCCESS) {
-            mpierr = ncmpii_error_mpi2nc(mpireturn, "MPI_File_sync");
-            if (status == NC_NOERR) status = mpierr;
-        }
-        TRACE_COMM(MPI_Barrier)(ncp->comm);
-        if (mpireturn != MPI_SUCCESS)
-            return ncmpii_error_mpi2nc(mpireturn, "MPI_Barrier");
-    }
-#endif
     return status;
 }