Skip to content

Commit 264c64d

Browse files
committed
Merge remote-tracking branch 'upstream/main'
2 parents c2128bc + a318dd7 commit 264c64d

File tree

2 files changed

+15
-25
lines changed

2 files changed

+15
-25
lines changed

CHANGELOG.md

Lines changed: 0 additions & 19 deletions
Original file line numberDiff line numberDiff line change
@@ -3,25 +3,6 @@
33
All notable changes to this project will be documented in this file.
44
and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0.html).
55

6-
## [0.6.13766604452] - 2025-03-10
7-
8-
9-
10-
## [0.6.13289211368] - 2025-02-12
11-
12-
- Fixed some small bugs that would make the deploy fail when updating the pd devops in some scenarios where tools where missing
13-
- fixes # (issue)
14-
15-
## [0.6.13282186908] - 2025-02-12
16-
17-
18-
19-
## [0.6.12926508568] - 2025-01-23
20-
21-
- Updated the discord announcement script
22-
- Added a script to get the beta changelog
23-
- Updated the way we generate release notes to match the type of release
24-
256
## [0.5.13] - 2025-01-22
267

278
- Please include a summary of the change and which issue is fixed. Please also include relevant motivation and context. List any dependencies that are required for this change.

internal/deploy/devops_service.go

Lines changed: 15 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -139,12 +139,21 @@ func (c *DevOpsServiceClient) InstallDependencies(ctx context.Context, listToIns
139139
if err != nil {
140140
return installed_dependencies, errors.New("Error setting up sudo access for brew without password, error: " + err.Error())
141141
}
142-
// adding access to /usr/local/share to the local user for brew
143-
cmd = "sudo"
144-
arguments := []string{"chown", "-R", "$(whoami):$(id -g)", "/usr/local/share"}
142+
143+
// adding access to /usr/local/share to the local user for brew if the folder exist, this is due to an issue with the permissions
144+
// on some mac intel machines
145+
// first we will check if the folder exists
146+
cmd = "ls"
147+
arguments := []string{"/usr/local/share"}
145148
_, err = c.client.RunCommand(cmd, arguments)
146-
if err != nil {
147-
return installed_dependencies, errors.New("Error setting up brew access to /usr/local/share, error: " + err.Error())
149+
if err == nil {
150+
// if the folder does exist we will set the permissions
151+
cmd = "sudo"
152+
arguments := []string{"chown", "-R", "$(whoami):$(id -g)", "/usr/local/share"}
153+
_, err = c.client.RunCommand(cmd, arguments)
154+
if err != nil {
155+
return installed_dependencies, errors.New("Error setting up brew access to /usr/local/share, error: " + err.Error())
156+
}
148157
}
149158

150159
case "git":
@@ -539,7 +548,7 @@ func (c *DevOpsServiceClient) InstallDevOpsService(ctx context.Context, license
539548

540549
devopsPath = c.findPath(ctx, "prldevops")
541550
if devopsPath == "" {
542-
return "", errors.New("Error running devops install command, error: brew not found")
551+
return "", errors.New("Error running devops install command, error: prldevops exec was not found")
543552
}
544553

545554
folderPath := c.findPathFolder(ctx, "prldevops")

0 commit comments

Comments
 (0)