further fixed to the build issues

Author: cjlapao

.github/workflows/documentation.yml

@@ -16,17 +16,6 @@ env:
   GO111MODULE: on
 
 jobs:
-  markdown-link-check:
-    runs-on: ubuntu-latest
-    steps:
-      - uses: actions/checkout@v4
-      - uses: gaurav-nelson/github-action-markdown-link-check@1.0.15
-        with:
-          use-quiet-mode: 'yes'
-          use-verbose-mode: 'yes'
-          config-file: '.markdownlinkcheck.json'
-          folder-path: 'docs'
-          file-extension: '.md'
   markdown-lint:
     runs-on: ubuntu-latest
     steps:

.github/workflows/pull_request.yml

@@ -29,7 +29,41 @@ jobs:
         run: make check-release
       - name: Fail if changes
         run: git diff-index --exit-code HEAD
-
+  markdown-link-check:
+    runs-on: ubuntu-latest
+    steps:
+      - uses: actions/checkout@v4
+      - uses: gaurav-nelson/github-action-markdown-link-check@1.0.15
+        with:
+          use-quiet-mode: 'yes'
+          use-verbose-mode: 'yes'
+          config-file: '.markdownlinkcheck.json'
+          folder-path: 'docs'
+          file-extension: '.md'
+  markdown-lint:
+    runs-on: ubuntu-latest
+    steps:
+      - uses: actions/checkout@v4
+      - uses: avto-dev/markdown-lint@v1.5.0
+        with:
+          config: '.markdownlint.yml'
+          args: 'docs'
+  misspell:
+    runs-on: ubuntu-latest
+    steps:
+      # Checkout should always be before setup-go to ensure caching is working
+      - uses: actions/checkout@v4
+      - uses: actions/setup-go@v5
+        with:
+          go-version: ${{ env.GO_VERSION }}
+      - uses: actions/cache@v4
+        continue-on-error: true
+        timeout-minutes: 2
+        with:
+          path: ~/go/pkg/mod
+          key: ${{ runner.os }}-go-pkg-mod-${{ hashFiles('go.sum') }}
+      - run: go install github.com/client9/misspell/cmd/misspell@latest
+      - run: misspell -error -source text docs/
   gosec_scan:
     runs-on: ubuntu-latest
     env:
@@ -49,7 +83,12 @@ jobs:
   # Run acceptance tests in a matrix with Terraform CLI versions
   test:
     name: Terraform Provider Acceptance Tests
-    needs: [build, gosec_scan]
+    needs:
+      - build
+      - gosec_scan
+      - markdown-link-check
+      - markdown-lint
+      - misspell
     runs-on: ubuntu-latest
     timeout-minutes: 15
     strategy:

.markdownlint.yml

@@ -18,6 +18,7 @@ MD014: false
 MD022: false
 MD024: false
 MD034: false
+MD033: false
 MD038: false
 MD040: false
 MD047: false

Makefile

@@ -6,9 +6,8 @@ TFPROVIDERLINT = tfproviderlint
 DEPS_TOOLS = deps_tools
 GOFUMPT = gofumpt
 TFDOCS-PLUGIN = tfdocs-plugin
-GH_CLIENT = GH_CLIENT
 
-DEVELOPMENT_TOOLS = $(GOX) $(GOLANGCI_LINT) $(TFPROVIDERLINT) $(GOFUMPT) $(TFDOCS-PLUGIN) $(GH_CLIENT)
+DEVELOPMENT_TOOLS = $(GOX) $(GOLANGCI_LINT) $(TFPROVIDERLINT) $(GOFUMPT) $(TFDOCS-PLUGIN)
 SECURITY_TOOLS = $(GOSEC)
 
 MARKDOWNLINT_IMG := 06kellyjac/markdownlint-cli
@@ -109,8 +108,4 @@ $(DEPS_TOOLS):
 	@cd tools && go get github.com/bflad/tfproviderlint/cmd/tfproviderlint
 	@cd tools && go get github.com/golangci/golangci-lint/cmd/golangci-lint
 	@cd tools && go mod tidy
-	@go generate -tags tools tools/tools.go
-
-$(GH_CLIENT):
-	@echo "Installing GitHub CLI..."
-	@brew install gh
+	@go generate -tags tools tools/tools.go