Merge pull request #237 from girly-coder01/fix/issues-176-177-178-179

fix: resolve issues #176, #177, #178, #179 - error handling, tests, and overflow fixes

Author: nonsobethel0-dev

contracts/claims-processor/src/lib.rs

@@ -592,6 +592,14 @@ impl ClaimsProcessor {
         // without bound.
         Self::remove_from_pending(env, claim.id);
 
+        // Emit specific event for rejected claims to enable off-chain monitoring
+        if !trigger_met {
+            env.events().publish(
+                (Symbol::new(env, "claim_rejected"),),
+                (claim.id, claim.policy_id, Symbol::new(env, "trigger_not_met")),
+            );
+        }
+
         env.events().publish(
             (Symbol::new(env, "claim_settled"), claim.id),
             (claim.trigger_met, claim.coverage_amount),

contracts/governance-dao/src/lib.rs

@@ -56,6 +56,7 @@ pub enum Error {
     AlreadyCancelled = 12,
     TimelockNotExpired = 13,
     FinalizeDelayNotMet = 14,
+    VersionNotNewer = 15,
 }
 
 #[contract]
@@ -544,7 +545,7 @@ impl GovernanceDao {
         Self::require_admin(&env, &admin);
         let current_version: u32 = env.storage().instance().get(&StorageKey::Version).unwrap_or(1);
         if new_version <= current_version {
-            panic!("new version must be greater than current version");
+            panic_with_error!(&env, Error::VersionNotNewer);
         }
 
         // Run migrations from current_version to new_version

contracts/policy-engine/src/test.rs

@@ -806,7 +806,7 @@ fn test_upgrade_increments_version() {
 fn test_multiple_upgrades_track_version_correctly() {
     let (env, admin, _oracle, _usdc, contract_id) = setup();
     let client = PolicyEngineClient::new(&env, &contract_id);
-    
+
     assert_eq!(client.get_version(), 1);
     client.upgrade(&admin, &BytesN::from_array(&env, &[1u8; 32]), &2);
     assert_eq!(client.get_version(), 2);

contracts/risk-pool/src/lib.rs

@@ -88,6 +88,7 @@ pub enum Error {
     NoPendingWithdrawal = 16,
     InsufficientShares  = 17,
     DepositTooSmall     = 18,
+    Overflow            = 19,
 }
 
 #[contract]
@@ -333,7 +334,10 @@ impl RiskPool {
         if total_shares > 0 {
             let acc_per_share: i128 = env.storage().instance()
                 .get(&StorageKey::AccumulatedPerShare).unwrap_or(0);
-            let increment = (lp_share * 1_000_000_000_000) / total_shares;
+            let increment = lp_share
+                .checked_mul(1_000_000_000_000)
+                .and_then(|v| v.checked_div(total_shares))
+                .unwrap_or_else(|| panic_with_error!(&env, Error::Overflow));
             env.storage().instance().set(&StorageKey::AccumulatedPerShare, &(acc_per_share + increment));
         }