✨ Add hostname resolve when master host is not ip address

Fixes #1

Signed-off-by: Muhammed Hussein Karimi <[email protected]>

Author: mhkarimi1383

haproxy_redis_sentinel/handler.py

@@ -1,7 +1,8 @@
+from socket import gethostbyname
 from time import sleep
 from typing import Any
 from enum import StrEnum
-from utils import send_command, is_empty
+from utils import is_ipv4, send_command, is_empty
 from redis import Redis
 from redis.retry import Retry
 from redis.backoff import FullJitterBackoff
@@ -131,6 +132,11 @@ def add_server(self, address: str):
         Add a new server to HAProxy (Used for initial sets).
             :param address: Address of the new server
         """
+        host = address.split(":")[0]
+        port = address.split(":")[1]
+        if not is_ipv4(host):
+            host = gethostbyname(host)
+        address = f"{host}:{port}"
         out = self.send_command(
             f"add server {self.haproxy_backend}/{self.haproxy_server_name} {address}"  # noqa: E501
         )
@@ -146,6 +152,8 @@ def set_server_address(self, host: str, port: int):
             :param host: Host of the new server
             :param port: Port of the new server
         """
+        if not is_ipv4(host):
+            host = gethostbyname(host)
         self.send_command(
             [
                 f"set server {self.haproxy_backend}/{self.haproxy_server_name} addr {host}",  # noqa: E501

haproxy_redis_sentinel/utils.py

@@ -1,6 +1,19 @@
 import socket
+import re
 
-__all__ = ["send_command", "is_empty"]
+__all__ = ["send_command", "is_empty", "is_ipv4"]
+
+
+def is_ipv4(ip: str) -> bool:
+    """
+    Check if a given string is a valid IP address.
+        :param ip: IP address to check
+        :return: True if valid, False otherwise
+    """
+    pattern = re.compile(
+        r"^((25[0-5]|2[0-4][0-9]|[01]?[0-9][0-9]?)\.){3}(25[0-5]|2[0-4][0-9]|[01]?[0-9][0-9]?)$"  # noqa: E501
+    )
+    return bool(pattern.match(ip))
 
 
 def encode_command(command: str) -> bytes: