Skip to content

Feedback: 'NServiceBus sagas: Integrations' #8005

@mnadareski-particular

Description

@mnadareski-particular

Feedback for 'NServiceBus sagas: Integrations' https://docs.particular.net/tutorials/nservicebus-sagas/3-integration/

Location in GitHub: https://github.com/Particular/docs.particular.net/blob/master/tutorials/nservicebus-sagas/3-integration/tutorial.md

  • In VSCode, when implementing the IAmStartedByMessages interface, it does not default to making the Handle method async, for some reason. I'm unsure if this is due to the interface being not marked as async or if this is VSCode-specific
  • Minor nitpick: In the code snippet for implementing ShipOrderWorkflow, it indicates that there should be more below the ShipOrderData class definition. This feels misleading as any additional code is added distinctly in other steps. I think this could reasonably show the end of the class instead
  • Under "Calling web services", the additional routing entries cause an issue if copied directly. This is due to the UseTransport method call not having the output saved to a variable if all previous steps are followed. Copying the identical code from ClientUI solves this.

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions