Fix or mask static code warnings from luaLS

Author: Musholic

spec/System/TestTradeQueryRequests_spec.lua

@@ -70,6 +70,7 @@ describe("TradeQueryRequests", function()
 		it("retries on 429 with exponential backoff", function()
 			local orig_os_time = os.time
 			local mock_time = 1000
+			---@diagnostic disable-next-line: duplicate-set-field
 			os.time = function() return mock_time end
 
 			local request = {
@@ -192,4 +193,4 @@ describe("TradeQueryRequests", function()
 			requests.FetchResultBlock = orig_fetchBlock
 		end)
 	end)
-end)
+end)

src/Classes/CalcsTab.lua

@@ -192,7 +192,7 @@ Effective DPS: Curses and enemy properties (such as resistances and status condi
 	self.powerBuilderInitialized = nil
 end)
 
-function CalcsTabClass:Load(xml, dbFileName)
+function CalcsTabClass:Load(xml, fileName)
 	for _, node in ipairs(xml) do
 		if type(node) == "table" then
 			if node.elem == "Input" then
@@ -631,7 +631,7 @@ function CalcsTabClass:PowerBuilder()
 
 	-- Calculate the impact of every cluster notable
 	-- used for the power report screen
-	for nodeName, node in pairs(self.build.spec.tree.clusterNodeMap) do
+	for nodeId, node in pairs(self.build.spec.tree.clusterNodeMap) do
 		if not node.power then
 			node.power = {}
 		end

src/Classes/ControlHost.lua

@@ -60,7 +60,7 @@ function ControlHostClass:ProcessControlsInput(inputEvents, viewPort)
 				inputEvents[id] = nil
 			end
 
-			local mOverControl = self:GetMouseOverControl(viewPort)
+			local mOverControl = self:GetMouseOverControl()
 
 			-- Avoid calculating isMouseInRegion as much as possible as it's expensive
 			if mOverControl and (not selControl or mOverControl.OnHoverKeyUp) then

src/Classes/EditControl.lua

@@ -297,7 +297,7 @@ function EditClass:Draw(viewPort, noTooltip)
 		else
 			SetDrawColor(self.inactiveCol)
 			if self.inactiveText then
-				local inactiveText = type(inactiveText) == "string" and self.inactiveText or self.inactiveText(self.buf)
+				local inactiveText = type(self.inactiveText) == "string" and self.inactiveText or self.inactiveText(self.buf)
 				DrawString(-self.controls.scrollBarH.offset, -self.controls.scrollBarV.offset, "LEFT", textHeight, self.font, inactiveText)
 			elseif self.protected then
 				DrawString(-self.controls.scrollBarH.offset, -self.controls.scrollBarV.offset, "LEFT", textHeight, self.font, string.rep(protected_replace, #self.buf))

src/Classes/GemSelectControl.lua

@@ -309,7 +309,7 @@ function GemSelectClass:UpdateSortCache()
 		sortCache.dps[gemId] = baseDPS
 		-- Ignore gems that don't support the active skill
 		if sortCache.canSupport[gemId] or (gemData.grantedEffect.hasGlobalEffect and not gemData.grantedEffect.support) then
-			local output = self:CalcOutputWithThisGem(calcFunc, gemData, useFullDPS, fastCalcOptions, calcBase)
+			local output = self:CalcOutputWithThisGem(calcFunc, gemData, useFullDPS)
 			-- Check for nil because some fields may not be populated, default to 0
 			sortCache.dps[gemId] = (dpsField == "FullDPS" and output[dpsField] ~= nil and output[dpsField]) or (output.Minion and output.Minion.CombinedDPS) or (output[dpsField] ~= nil and output[dpsField]) or 0
 		end
@@ -452,7 +452,7 @@ function GemSelectClass:Draw(viewPort, noTooltip)
 			if calcFunc then
 				self.tooltip:Clear()
 				local gemData = self.gems[self.list[self.hoverSel]]
-				local output = self:CalcOutputWithThisGem(calcFunc, gemData, self.skillsTab.sortGemsByDPSField == "FullDPS", nil, calcBase)
+				local output = self:CalcOutputWithThisGem(calcFunc, gemData, self.skillsTab.sortGemsByDPSField == "FullDPS")
 				local gemInstance = {
 						level = self.skillsTab:ProcessGemLevel(gemData),
 						quality = self.skillsTab.defaultGemQuality or 0,
@@ -911,4 +911,4 @@ function GemSelectClass:OnKeyUp(key)
 	end
 	local newSel = self.EditControl:OnKeyUp(key)
 	return newSel == self.EditControl and self or newSel
-end
+end

src/Classes/ModDB.lua

@@ -209,7 +209,7 @@ function ModDBClass:ListInternal(context, result, cfg, flags, keywordFlags, sour
 				if mod.type == "LIST" and band(flags, mod.flags) == mod.flags and MatchKeywordFlags(keywordFlags, mod.keywordFlags) and (not source or mod.source:match("[^:]+") == source) then
 					local value
 					if mod[1] then
-						local value = context:EvalMod(mod, cfg) or nullValue
+						local value = context:EvalMod(mod, cfg) or nil
 						if value then
 							t_insert(result, value)
 						end
@@ -315,4 +315,4 @@ function ModDBClass:Print()
 	for i, name in ipairs(nameList) do
 		ConPrintf("%s = %d", name, self.multipliers[name])
 	end
-end
+end

src/Classes/ModList.lua

@@ -179,7 +179,7 @@ function ModListClass:ListInternal(context, result, cfg, flags, keywordFlags, so
 			if mod.name == modName and mod.type == "LIST" and band(flags, mod.flags) == mod.flags and MatchKeywordFlags(keywordFlags, mod.keywordFlags) and (not source or mod.source:match("[^:]+") == source) then
 				local value
 				if mod[1] then
-					local value = context:EvalMod(mod, cfg) or nullValue
+					local value = context:EvalMod(mod, cfg) or nil
 					if value then
 						t_insert(result, value)
 					end

src/Classes/ModStore.lua

@@ -278,6 +278,7 @@ function ModStoreClass:GetStat(stat, cfg)
 		local totalLife = self.actor.output["Life"]
 		if totalLife == 0 then return 0 else
 			for _, activeSkill in ipairs(self.actor.activeSkillList) do
+				---@diagnostic disable-next-line: undefined-global
 				if (activeSkill.skillTypes[SkillType.HasReservation] and not activeSkill.skillFlags.disable and activeSkill.buffList and activeSkill.buffList[1] and cfg and (isNameInBuffList(activeSkill.buffList, cfg.skillName) or isNameInBuffList(activeSkill.buffList, cfg.summonSkillName)) ) then
 					local lifeBase = activeSkill.skillData["LifeReservedBase"] or 0
 					reservedPercentLife = lifeBase / totalLife * 100
@@ -863,4 +864,4 @@ function ModStoreClass:EvalMod(mod, cfg, globalLimits)
 		end
 	end
 	return value
-end
+end

src/Classes/PartyTab.lua

@@ -191,9 +191,11 @@ local PartyTabClass = newClass("PartyTab", "ControlHost", "Control", function(se
 		-- Parse the XML
 		local dbXML, errMsg = common.xml.ParseXML(self.importCodeXML)
 		if not dbXML then
+			---@diagnostic disable-next-line: undefined-global
 			launch:ShowErrMsg("^1Error loading '%s': %s", fileName, errMsg)
 			return
 		elseif dbXML[1].elem ~= "PathOfBuilding2" then
+			---@diagnostic disable-next-line: undefined-global
 			launch:ShowErrMsg("^1Error parsing '%s': 'PathOfBuilding2' root element missing", fileName)
 			return
 		end
@@ -908,6 +910,7 @@ function PartyTabClass:ParseBuffs(list, buf, buffType, label)
 					end
 				end
 				if list["AuraDebuff"] and list["AuraDebuff"]["Vaal"] then
+					---@diagnostic disable-next-line: undefined-global
 					if not list["Aura"] or not list["Aura"]["Vaal"] or not list["Aura"]["Vaal"][aura] then
 						for aura, auraMod in pairs(list["AuraDebuff"]["Vaal"]) do
 							t_insert(labelList, aura..": "..auraMod.effectMult.."%\n")
@@ -1032,4 +1035,4 @@ function PartyTabClass:exportBuffs(buffType)
 	self.buffExports[buffType] = { ConvertedToText = true }
 	self.buffExports[buffType].string = buf
 	return buf
-end
+end

src/Classes/PassiveSpec.lua

@@ -2255,7 +2255,7 @@ end
 --- Adds a line to or replaces a node given a line to add/replace with
 --- @param node table The node to replace/add to
 --- @param sd string The line being parsed and added
---- @param replacement boolean true to replace the node with the new mod, false to simply add it
+--- @param replacement boolean? true to replace the node with the new mod, false to simply add it
 function PassiveSpecClass:NodeAdditionOrReplacementFromString(node,sd,replacement)
 	local addition = {}
 	addition.sd = {sd}