Fix logic, extend functionality.

Author: thet

src/pat/validation/validation.js

@@ -260,35 +260,49 @@ class Pattern extends BasePattern {
                     this.check_input({ input: not_before_el, stop: true });
                 }
             } else if (input_options.minValues || input_options.maxValues) {
-
                 const min_values = input_options.minValues !== null && parseInt(input_options.minValues, 10)
                 const max_values = input_options.maxValues !== null && parseInt(input_options.maxValues, 10)
 
-                // This makes only sense for inputs with the same name.
-                const valued_siblings = [...this.el.elements].filter((el) => {
+                let number_values = 0;
+                for (const _inp of this.el.elements) {
                     // Filter for siblings with same name.
-                    if (el.name !== input.name) {
-                        return false;
+                    if (
+                        // Keep only inputs with same name
+                        _inp.name !== input.name
+                        // Skip all form elements which are no input elements
+                        || ! ["INPUT", "SELECT", "TEXTAREA"].includes(_inp.tagName)
+                    ) {
+                        continue;
                     }
 
-                    // Check if checkboxes or radios are selected ...
-                    if (el.type === "checkbox" || el.type === "radio") {
-                        return el.checked;
+                    // Check if checkboxes or radios are checked ...
+                    if (_inp.type === "checkbox" || _inp.type === "radio") {
+                        if (_inp.checked) {
+                            number_values++;
+                        }
+                        continue;
                     }
 
-                    // ... or inputs have a value set.
-                    // TODO: are multiple non-check/radio inputs with same name even possible?
-                    return el.value !== undefined;
-                });
+                    // Select, if select is selected.
+                    if (_inp.tagName === "SELECT") {
+                        number_values += _inp.selectedOptions.length;
+                        continue;
+                    }
+
+                    // For the rest a value must be set.
+                    if (_inp.value === 0 || _inp.value) {
+                        number_values++;
+                    }
+                }
 
-                if (max_values !== null && valued_siblings.length > max_values) {
+                if (max_values !== null && number_values > max_values) {
                     this.set_error({
                         input: input,
                         msg: input_options.message["max-values"],
                         max: max_values,
                     })
                 }
-                if (min_values !== null && valued_siblings.length < min_values) {
+                if (min_values !== null && number_values < min_values) {
                     this.set_error({
                         input: input,
                         msg: input_options.message["min-values"],