Skip to content
This repository was archived by the owner on Jul 2, 2019. It is now read-only.
This repository was archived by the owner on Jul 2, 2019. It is now read-only.

Missing tongue_amplitude update #16

@dkadish

Description

@dkadish

voc/top.w

Lines 224 to 239 in 20a17d6

SPFLOAT grid_offset = 1.7;
SPFLOAT fixed_tongue_diameter = 2+(tongue_diameter-2)/1.5;
SPFLOAT tongue_amplitude = (1.5 - fixed_tongue_diameter + grid_offset);
int i;
SPFLOAT t;
SPFLOAT curve;
for(i = blade_start; i < lip_start; i++) {
t = 1.1 * M_PI *
(SPFLOAT)(tongue_index - i)/(tip_start - blade_start);
fixed_tongue_diameter = 2+(tongue_diameter-2)/1.5;
curve = tongue_amplitude * cos(t);
if(i == lip_start - 1) curve *= 0.8;
if(i == blade_start || i == lip_start - 2) curve *= 0.94;
diameters[i] = 1.5 - curve;
}

I think that an update to tongue_amplitude is missing in line 234-235. In line 226, it is updated using the value of fixed_tongue_diameter, but within the loop, the new value of fixed_tongue_diameter goes unused as tongue_amplitude is not updated...

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions