Skip to content

Fragile URL parsing via string split in settings controllers #158

@stultus

Description

@stultus

File: app/settings/controllers.py (lines 135, 152)

Description

Both delete_url() and delete_comment() extract URLs using request.args.get('url').split('get?url=')[1]. This raises an IndexError if the parameter format doesn't match, and raises an AttributeError if the parameter is missing entirely (None.split()).

Metadata

Metadata

Assignees

No one assigned

    Labels

    bugSomething isn't workingmediumMedium severity

    Type

    No type
    No fields configured for issues without a type.

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions