Opening up TestIAMRoleCanIssueSelectFromS3 for dynamic CLICKHOUSE connection parameters and skipping if FLOW_TESTS_AWS_S3_BUCKET_NAME is not passed. It will only be run locally if that env-var is passed

Author: pfcoperez

flow/connectors/clickhouse/s3_iam_role_test.go

@@ -3,6 +3,7 @@ package connclickhouse
 import (
 	"fmt"
 	"os"
+	"strconv"
 	"testing"
 	"time"
 
@@ -13,6 +14,11 @@ import (
 )
 
 func TestIAMRoleCanIssueSelectFromS3(t *testing.T) {
+	const bucketNameEnvVar = "FLOW_TESTS_AWS_S3_BUCKET_NAME"
+	if os.Getenv(bucketNameEnvVar) == "" {
+		t.Skipf("skipping test since %s is not set", bucketNameEnvVar)
+	}
+
 	for _, envVar := range []string{
 		"AWS_ACCESS_KEY_ID",
 		"AWS_SECRET_ACCESS_KEY",
@@ -34,13 +40,24 @@ func TestIAMRoleCanIssueSelectFromS3(t *testing.T) {
 	} {
 		t.Setenv(envVar, os.Getenv("FLOW_TESTS_"+envVar))
 	}
-	t.Setenv("PEERDB_CLICKHOUSE_AWS_S3_BUCKET_NAME", os.Getenv("FLOW_TESTS_AWS_S3_BUCKET_NAME"))
+	t.Setenv("PEERDB_CLICKHOUSE_AWS_S3_BUCKET_NAME", os.Getenv(bucketNameEnvVar))
 	ctx := t.Context()
 
+	chHost := "localhost"
+	if host := os.Getenv("CI_CLICKHOUSE_HOST"); host != "" {
+		chHost = host
+	}
+	var chPort uint32 = 9000
+	if port := os.Getenv("CI_CLICKHOUSE_NATIVE_PORT"); port != "" {
+		if p, err := strconv.ParseUint(port, 10, 32); err == nil {
+			chPort = uint32(p)
+		}
+	}
+
 	conn, err := NewClickHouseConnector(ctx, nil,
 		&protos.ClickhouseConfig{
-			Host:       "localhost",
-			Port:       9000,
+			Host:       chHost,
+			Port:       chPort,
 			Database:   "default",
 			DisableTls: true,
 		})