Skip to content

Commit 1287d2a

Browse files
Jeremyyang920claude
andcommitted
Address review (ilidemi)
- labeler.yml: header comment lists S3 as deprecated and notes ClickHouse/Postgres as the excluded (maintained) destinations; add the BigQuery destination QRep file (qrep.go) to the tracked paths. - CONTRIBUTING.md: add S3 to the deprecated list; note BigQuery is deprecated only as a destination. - bug_report.yml: drop the duplicate migration-guide link. - feature_request.yml: new issue-form template so feature requests have a home while the chooser stays curated (blank issues remain disabled). - Issue forms: add an optional "Source connector" dropdown and make the destination dropdown optional, so source-side issues aren't forced to pick a destination (GitHub issue forms have no conditional fields). The destination dropdown keeps its exact label so the deprecation-triage workflow still parses it. Refs #4465 Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
1 parent ec0bc91 commit 1287d2a

4 files changed

Lines changed: 99 additions & 7 deletions

File tree

.github/ISSUE_TEMPLATE/bug_report.yml

Lines changed: 18 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -38,20 +38,34 @@ body:
3838
validations:
3939
required: true
4040

41+
- type: dropdown
42+
id: source_connector
43+
attributes:
44+
label: Source connector
45+
description: If this issue relates to a source connector, select it here. Leave blank if not applicable.
46+
options:
47+
- Postgres
48+
- MySQL
49+
- MongoDB
50+
- BigQuery
51+
- Other
52+
validations:
53+
required: false
54+
4155
- type: markdown
4256
attributes:
4357
value: |
4458
### ⚠️ Deprecated destination connectors
4559
4660
The following destination connectors are **deprecated**: **Snowflake**, **BigQuery**, **ElasticSearch**, **Kafka**, **Redpanda**, **Confluent**, **Azure Event Hubs**, **Google Pub/Sub**, and **S3**.
4761
48-
These destinations are no longer actively maintained, but remain functional. Bugs affecting only these destinations are unlikely to be prioritized. Note: BigQuery is deprecated **only as a destination** — it remains a supported source. See the [deprecated connectors documentation](https://github.com/PeerDB-io/peerdb/blob/main/docs/deprecated-connectors.md) ([../../docs/deprecated-connectors.md](../../docs/deprecated-connectors.md)) for details and migration guidance.
62+
These destinations are no longer actively maintained, but remain functional. Bugs affecting only these destinations are unlikely to be prioritized. Note: BigQuery is deprecated **only as a destination** — it remains a supported source. See the [deprecated connectors documentation](https://github.com/PeerDB-io/peerdb/blob/main/docs/deprecated-connectors.md) for details and migration guidance.
4963
5064
- type: dropdown
5165
id: destination_connector
5266
attributes:
5367
label: Destination connector
54-
description: Which destination connector is affected? (See the deprecation notice above.)
68+
description: If this issue relates to a destination connector, select it here (see the deprecation notice above). Leave blank if not applicable.
5569
options:
5670
- ClickHouse
5771
- ClickHouse Cloud
@@ -65,6 +79,6 @@ body:
6579
- Confluent
6680
- Azure Event Hubs
6781
- Google Pub/Sub
68-
- Other / N/A
82+
- Other
6983
validations:
70-
required: true
84+
required: false
Lines changed: 77 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,77 @@
1+
name: Feature request
2+
description: Suggest a feature or improvement for PeerDB
3+
title: "[Feature]: "
4+
labels: ["enhancement"]
5+
body:
6+
- type: markdown
7+
attributes:
8+
value: |
9+
Thanks for suggesting an improvement! Please describe the problem you are trying to solve and what you would like to happen.
10+
11+
- type: textarea
12+
id: problem
13+
attributes:
14+
label: Problem / motivation
15+
description: What problem are you trying to solve, and what is the use case?
16+
placeholder: When replicating ..., I need ... but currently ...
17+
validations:
18+
required: true
19+
20+
- type: textarea
21+
id: proposal
22+
attributes:
23+
label: Proposed solution
24+
description: Describe what you would like to happen.
25+
validations:
26+
required: true
27+
28+
- type: textarea
29+
id: alternatives
30+
attributes:
31+
label: Alternatives considered
32+
description: Any alternative solutions or workarounds you have considered.
33+
validations:
34+
required: false
35+
36+
- type: dropdown
37+
id: source_connector
38+
attributes:
39+
label: Source connector
40+
description: If this request relates to a source connector, select it here. Leave blank if not applicable.
41+
options:
42+
- Postgres
43+
- MySQL
44+
- MongoDB
45+
- BigQuery
46+
- Other
47+
validations:
48+
required: false
49+
50+
- type: markdown
51+
attributes:
52+
value: |
53+
### ⚠️ Deprecated destination connectors
54+
55+
The following destination connectors are **deprecated** and no longer actively maintained: **Snowflake**, **BigQuery**, **ElasticSearch**, **Kafka**, **Redpanda**, **Confluent**, **Azure Event Hubs**, **Google Pub/Sub**, and **S3**. New features for these destinations are unlikely to be prioritized. Note: BigQuery is deprecated **only as a destination** — it remains a supported source. See the [deprecated connectors documentation](https://github.com/PeerDB-io/peerdb/blob/main/docs/deprecated-connectors.md).
56+
57+
- type: dropdown
58+
id: destination_connector
59+
attributes:
60+
label: Destination connector
61+
description: If this request relates to a destination connector, select it here (see the deprecation notice above). Leave blank if not applicable.
62+
options:
63+
- ClickHouse
64+
- ClickHouse Cloud
65+
- Postgres
66+
- S3
67+
- Snowflake
68+
- BigQuery
69+
- ElasticSearch
70+
- Kafka
71+
- Redpanda
72+
- Confluent
73+
- Azure Event Hubs
74+
- Google Pub/Sub
75+
- Other
76+
validations:
77+
required: false

.github/labeler.yml

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
11
# Configuration for actions/labeler@v5.
22
# Applies the `deprecated` label to PRs that touch deprecated destination connectors:
3-
# Snowflake, BigQuery, ElasticSearch, Kafka (incl. Confluent/Redpanda), Azure Event Hubs, Google Pub/Sub.
4-
# S3 and ClickHouse are intentionally excluded.
3+
# Snowflake, BigQuery, ElasticSearch, Kafka (incl. Confluent/Redpanda), Azure Event Hubs, Google Pub/Sub, S3.
4+
# ClickHouse and Postgres (the actively-maintained destinations) are intentionally excluded.
55
deprecated:
66
- changed-files:
77
- any-glob-to-any-file:
@@ -44,6 +44,7 @@ deprecated:
4444
# silently disables the whole labeler config in actions/labeler v5.)
4545
- flow/connectors/bigquery/bigquery.go
4646
- flow/connectors/bigquery/merge_stmt_generator.go
47+
- flow/connectors/bigquery/qrep.go
4748
- flow/connectors/bigquery/qrep_avro_sync.go
4849
- flow/connectors/bigquery/clustering.go
4950
- flow/e2e/bigquery_test.go

CONTRIBUTING.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -4,6 +4,6 @@ Thanks for your interest in contributing to PeerDB! Bug reports, feature request
44

55
## Deprecated connectors
66

7-
Several destination connectors (Snowflake, BigQuery, ElasticSearch, Kafka including Confluent and Redpanda, Azure Event Hubs, and Google Pub/Sub) are deprecated and no longer actively maintained. They remain fully functional, and no code is being removed.
7+
Several destination connectors (Snowflake, BigQuery, ElasticSearch, Kafka including Confluent and Redpanda, Azure Event Hubs, Google Pub/Sub, and S3) are deprecated and no longer actively maintained. They remain fully functional, and no code is being removed. (BigQuery is deprecated only as a destination — it remains a supported source.)
88

99
If you depend on one of these connectors, see the [deprecated connectors migration guide](docs/deprecated-connectors.md) for how to pin to a release or fork the relevant connector code.

0 commit comments

Comments
 (0)