Skip to content

Commit 256631d

Browse files
authored
Dedup sourcePeerType (#4499)
Already stamped on every metric
1 parent 7826ad6 commit 256631d

2 files changed

Lines changed: 0 additions & 2 deletions

File tree

flow/connectors/mysql/cdc.go

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1050,7 +1050,6 @@ func (c *MySqlConnector) recordColumnTypeChange(
10501050
eventType string,
10511051
) {
10521052
otelManager.Metrics.ColumnTypeChangesCounter.Add(ctx, 1, metric.WithAttributeSet(attribute.NewSet(
1053-
attribute.String(otel_metrics.SourcePeerType, "mysql"),
10541053
attribute.String(otel_metrics.TypeChangeFromKey, string(from)),
10551054
attribute.String(otel_metrics.TypeChangeToKey, string(to)),
10561055
attribute.String(otel_metrics.SourceEventTypeKey, eventType),

flow/connectors/postgres/cdc.go

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1306,7 +1306,6 @@ func processRelationMessage[Items model.Items](
13061306
p.logger.Warn(fmt.Sprintf("Detected column %s with type changed from %s to %s in table %s, but not propagating",
13071307
column.Name, prevRelMap[column.Name], currRelMap[column.Name], schemaDelta.SrcTableName))
13081308
p.otelManager.Metrics.ColumnTypeChangesCounter.Add(ctx, 1, metric.WithAttributeSet(attribute.NewSet(
1309-
attribute.String(otel_metrics.SourcePeerType, "postgres"),
13101309
attribute.String(otel_metrics.TypeChangeFromKey, prevRelMap[column.Name]),
13111310
attribute.String(otel_metrics.TypeChangeToKey, currRelMap[column.Name]),
13121311
attribute.String(otel_metrics.SourceEventTypeKey, otel_metrics.SourceEventTypeEventMetadata),

0 commit comments

Comments
 (0)