review

jgao54 · jgao54 · commit 38ff3aa9db70 · 2026-07-01T17:44:52.000-10:00
diff --git a/flow/connectors/external_metadata/store.go b/flow/connectors/external_metadata/store.go
@@ -270,7 +270,7 @@ func (p *PostgresMetadata) FinishQRepPartition(
 		// Clone rather than mutate in place because this partition is shared with the pull
 		// goroutine, cloning keeps us from relying on implicit ordering to avoid a write race.
 		// TODO: drop the sync_partition column entirely; nothing reads it back.
-		partition = proto.Clone(partition).(*protos.QRepPartition)
+		partition = proto.CloneOf(partition)
 		partition.Range = nil
 	}
 	pbytes, err := protojson.Marshal(partition)

Original file line number	Diff line number	Diff line change
`@@ -270,7 +270,7 @@ func (p *PostgresMetadata) FinishQRepPartition(`
`270`	`270`	`// Clone rather than mutate in place because this partition is shared with the pull`
`271`	`271`	`// goroutine, cloning keeps us from relying on implicit ordering to avoid a write race.`
`272`	`272`	`// TODO: drop the sync_partition column entirely; nothing reads it back.`
`273`		`- partition = proto.Clone(partition).(*protos.QRepPartition)`
	`273`	`+ partition = proto.CloneOf(partition)`
`274`	`274`	`partition.Range = nil`
`275`	`275`	`}`
`276`	`276`	`pbytes, err := protojson.Marshal(partition)`