Skip to content

Commit 501bec8

Browse files
committed
fix(lint): fix gci import ordering and nolint opaque for staging factory functions
1 parent 5508153 commit 501bec8

2 files changed

Lines changed: 8 additions & 6 deletions

File tree

flow/connectors/clickhouse/clickhouse.go

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -14,18 +14,18 @@ import (
1414
"strings"
1515
"time"
1616

17-
chproto "github.com/ClickHouse/ch-go/proto"
18-
"github.com/ClickHouse/clickhouse-go/v2"
19-
"github.com/ClickHouse/clickhouse-go/v2/lib/driver"
20-
clickhouseproto "github.com/ClickHouse/clickhouse-go/v2/lib/proto"
21-
"go.temporal.io/sdk/log"
22-
2317
metadataStore "github.com/PeerDB-io/peerdb/flow/connectors/external_metadata"
2418
"github.com/PeerDB-io/peerdb/flow/generated/protos"
2519
"github.com/PeerDB-io/peerdb/flow/internal"
2620
peerdb_clickhouse "github.com/PeerDB-io/peerdb/flow/pkg/clickhouse"
2721
"github.com/PeerDB-io/peerdb/flow/shared"
2822
"github.com/PeerDB-io/peerdb/flow/shared/types"
23+
24+
chproto "github.com/ClickHouse/ch-go/proto"
25+
"github.com/ClickHouse/clickhouse-go/v2"
26+
"github.com/ClickHouse/clickhouse-go/v2/lib/driver"
27+
clickhouseproto "github.com/ClickHouse/clickhouse-go/v2/lib/proto"
28+
"go.temporal.io/sdk/log"
2929
)
3030

3131
type ClickHouseConnector struct {

flow/connectors/clickhouse/staging.go

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -49,6 +49,7 @@ func createStagingStore(
4949
}
5050
}
5151

52+
//nolint:iface // factory function intentionally returns interface
5253
func newS3StagingStoreFromConfig(
5354
ctx context.Context,
5455
config *protos.ClickhouseConfig,
@@ -108,6 +109,7 @@ func newS3StagingStoreFromConfig(
108109
return newS3StagingStore(awsBucketPath, credentialsProvider)
109110
}
110111

112+
//nolint:iface // factory function intentionally returns interface
111113
func newGCSStagingStore(ctx context.Context, bucketName string) (StagingStore, error) {
112114
if bucketName == "" {
113115
return nil, errors.New("PEERDB_CLICKHOUSE_STAGING_BUCKET_NAME must be set when staging provider is gcs")

0 commit comments

Comments
 (0)