Skip to content

Commit 75e714e

Browse files
committed
Fix TestDropCompleted e2e test after change to use PG catalog by properly matching the expected error.
1 parent 902f92c commit 75e714e

1 file changed

Lines changed: 7 additions & 4 deletions

File tree

flow/e2e/api_test.go

Lines changed: 7 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -3,6 +3,7 @@ package e2e
33
import (
44
"context"
55
"database/sql"
6+
"errors"
67
"fmt"
78
"slices"
89
"strings"
@@ -1493,15 +1494,17 @@ func (s APITestSuite) TestDropCompleted() {
14931494
require.NoError(s.t, err)
14941495
EnvWaitFor(s.t, env, time.Minute, "wait for avro stage dropped", func() bool {
14951496
var workflowID string
1496-
return s.catalog.QueryRow(
1497+
err := s.catalog.QueryRow(
14971498
s.t.Context(), "SELECT avro_file FROM ch_s3_stage WHERE flow_job_name = $1", flowConnConfig.FlowJobName,
1498-
).Scan(&workflowID) == pgx.ErrNoRows
1499+
).Scan(&workflowID)
1500+
return errors.Is(err, pgx.ErrNoRows)
14991501
})
15001502
EnvWaitFor(s.t, env, time.Minute, "wait for flow dropped", func() bool {
15011503
var workflowID string
1502-
return s.catalog.QueryRow(
1504+
err := s.catalog.QueryRow(
15031505
s.t.Context(), "select workflow_id from flows where name = $1", flowConnConfig.FlowJobName,
1504-
).Scan(&workflowID) == pgx.ErrNoRows
1506+
).Scan(&workflowID)
1507+
return errors.Is(err, pgx.ErrNoRows)
15051508
})
15061509
}
15071510

0 commit comments

Comments
 (0)