Skip to content

Commit 820bcff

Browse files
authored
Remove incident.io telemetry (#4481)
Was only temporarily used after joining ClickHouse. The path also has SNS sender that's not exposed in UI and seems to have been a part of the decommissioned Cloud offering, will remove that separately if there aren't signs it's used elsewhere.
1 parent 28d132e commit 820bcff

6 files changed

Lines changed: 8 additions & 419 deletions

File tree

flow/alerting/alerting.go

Lines changed: 6 additions & 31 deletions
Original file line numberDiff line numberDiff line change
@@ -31,9 +31,8 @@ import (
3131
// alerting service, no cool name :(
3232
type Alerter struct {
3333
shared.CatalogPool
34-
snsTelemetrySender telemetry.Sender
35-
incidentIoTelemetrySender telemetry.Sender
36-
otelManager *otel_metrics.OtelManager
34+
snsTelemetrySender telemetry.Sender
35+
otelManager *otel_metrics.OtelManager
3736
}
3837

3938
type AlertSenderConfig struct {
@@ -66,26 +65,10 @@ func NewAlerter(ctx context.Context, catalogPool shared.CatalogPool, otelManager
6665
}
6766
}
6867

69-
incidentIoURL := internal.PeerDBGetIncidentIoUrl()
70-
incidentIoAuth := internal.PeerDBGetIncidentIoToken()
71-
var incidentIoTelemetrySender telemetry.Sender
72-
if incidentIoURL != "" && incidentIoAuth != "" {
73-
var err error
74-
incidentIoTelemetrySender, err = telemetry.NewIncidentIoMessageSender(ctx, telemetry.IncidentIoMessageSenderConfig{
75-
URL: incidentIoURL,
76-
Token: incidentIoAuth,
77-
})
78-
internal.LoggerFromCtx(ctx).Info("Successfully registered incident.io telemetry sender")
79-
if err != nil {
80-
panic(fmt.Sprintf("unable to setup incident.io telemetry is nil for Alerter %+v", err))
81-
}
82-
}
83-
8468
return &Alerter{
85-
CatalogPool: catalogPool,
86-
snsTelemetrySender: snsMessageSender,
87-
incidentIoTelemetrySender: incidentIoTelemetrySender,
88-
otelManager: otelManager,
69+
CatalogPool: catalogPool,
70+
snsTelemetrySender: snsMessageSender,
71+
otelManager: otelManager,
8972
}
9073
}
9174

@@ -401,14 +384,6 @@ func (a *Alerter) sendTelemetryMessage(
401384
logger.Debug("received response from snsTelemetrySender", slog.String("response", response))
402385
}
403386
}
404-
405-
if a.incidentIoTelemetrySender != nil {
406-
if status, err := a.incidentIoTelemetrySender.SendMessage(ctx, details, details, attributes); err != nil {
407-
logger.Warn("failed to send message to incidentIoTelemetrySender", slog.Any("error", err))
408-
} else {
409-
logger.Debug("received response from incident.io", slog.String("response", status))
410-
}
411-
}
412387
}
413388

414389
func (a *Alerter) emitNonFlowTelemetryEvent(
@@ -485,7 +460,7 @@ func (a *Alerter) recordFlowErrorInternal(
485460
logger.Error("failed to insert flow error", slog.Any("error", err))
486461
}
487462

488-
// 3. Only send alerts to telemetry sender (incident.io) if the env is enabled
463+
// 3. Only send alerts to telemetry sender if the env is enabled
489464
if internal.PeerDBTelemetrySenderSendErrorAlertsEnabled(ctx) {
490465
var tags []string
491466
if errors.Is(err, context.Canceled) {

flow/internal/config.go

Lines changed: 0 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -169,14 +169,6 @@ func PeerDBTemporalTLSServerName() string {
169169
return GetEnvString("TEMPORAL_TLS_SERVER_NAME", "")
170170
}
171171

172-
func PeerDBGetIncidentIoUrl() string {
173-
return GetEnvString("PEERDB_INCIDENTIO_URL", "")
174-
}
175-
176-
func PeerDBGetIncidentIoToken() string {
177-
return GetEnvString("PEERDB_INCIDENTIO_TOKEN", "")
178-
}
179-
180172
func PeerDBRAPIRequestLoggingEnabled(ctx context.Context) bool {
181173
requestLoggingEnabled, err := strconv.ParseBool(GetEnvString("PEERDB_API_REQUEST_LOGGING_ENABLED", "false"))
182174
if err != nil {

flow/shared/err_types.go

Lines changed: 0 additions & 14 deletions
Original file line numberDiff line numberDiff line change
@@ -25,20 +25,6 @@ const (
2525
ErrTypeEOF ErrType = "err:EOF"
2626
)
2727

28-
func SkipSendingToIncidentIo(errTags []string) bool {
29-
skipTags := map[string]struct{}{
30-
string(ErrTypeCanceled): {},
31-
string(ErrTypeClosed): {},
32-
string(ErrTypeNet): {},
33-
}
34-
for _, tag := range errTags {
35-
if _, ok := skipTags[tag]; ok {
36-
return true
37-
}
38-
}
39-
return false
40-
}
41-
4228
type QRepWarnings []error
4329

4430
func WrapError(s string, err error) error {

flow/shared/telemetry/incidentio_message_sender.go

Lines changed: 0 additions & 154 deletions
This file was deleted.

0 commit comments

Comments
 (0)