refactor(staging): add explicit s3 case and exhaustiveness check for provider

whites11 · whites11 · commit b3776af7e99b · 2026-05-06T09:46:34.000+02:00
diff --git a/flow/connectors/clickhouse/staging.go b/flow/connectors/clickhouse/staging.go
@@ -33,10 +33,12 @@ func createStagingStore(
 	}
 
 	switch strings.ToLower(provider) {
+	case "s3", "":
+		return newS3StagingStoreFromConfig(ctx, config, bucketName, chVersion)
 	case "gcs":
 		return newGCSStagingStore(ctx, bucketName)
 	default:
-		return newS3StagingStoreFromConfig(ctx, config, bucketName, chVersion)
+		return nil, fmt.Errorf("unsupported staging provider %q (expected s3 or gcs)", provider)
 	}
 }
 

Original file line number	Diff line number	Diff line change
`@@ -33,10 +33,12 @@ func createStagingStore(`
`33`	`33`	`}`
`34`	`34`
`35`	`35`	`switch strings.ToLower(provider) {`
	`36`	`+ case "s3", "":`
	`37`	`+ return newS3StagingStoreFromConfig(ctx, config, bucketName, chVersion)`
`36`	`38`	`case "gcs":`
`37`	`39`	`return newGCSStagingStore(ctx, bucketName)`
`38`	`40`	`default:`
`39`		`- return newS3StagingStoreFromConfig(ctx, config, bucketName, chVersion)`
	`41`	`+ return nil, fmt.Errorf("unsupported staging provider %q (expected s3 or gcs)", provider)`
`40`	`42`	`}`
`41`	`43`	`}`
`42`	`44`