fix: revert pgx macaddr fix and pin pgx v5.8.0 to exclude v5.9.x

Pin github.com/jackc/pgx/v5 to v5.8.0 in flow/go.mod and flow/pkg/go.mod
with exclude directives blocking v5.9.0–v5.9.2, and add it to the pinned
versions checker. Reverts the v5.9 binary-array workaround in
qvalue_convert.go — the proper fix will be tackled separately.

Co-authored-by: Ilia Demianenko <ilidemi@users.noreply.github.com>

Author: github-actions[bot]

flow/cmd/check_pinned_versions/main.go

@@ -21,6 +21,7 @@ var pinnedVersions = map[string]string{
 	"cloud.google.com/go/pubsub/v2":                   "v2.3.0",
 	"cloud.google.com/go/storage":                     "v1.59.2",
 	"github.com/aws/aws-sdk-go-v2/feature/s3/manager": "v1.21.0",
+	"github.com/jackc/pgx/v5":                         "v5.8.0",
 	"google.golang.org/api":                           "v0.257.0",
 	"github.com/tikv/pd/client":                       "v0.0.0-20251229071808-6173d50c004c",
 }

flow/connectors/postgres/qvalue_convert.go

@@ -339,30 +339,6 @@ func (c *PostgresConnector) convertToStringArray(kind types.QValueKind, oid uint
 	switch v := value.(type) {
 	case pgtype.Array[string]:
 		if v.Valid {
-			// pgx v5.9+ may return binary-encoded elements (e.g. macaddr as 6 raw bytes).
-			// Detect this by checking if the array type has a known element codec and
-			// attempting a binary→text re-scan for each non-empty element.
-			if t, ok := c.typeMap.TypeForOID(oid); ok {
-				if ac, ok := t.Codec.(*pgtype.ArrayCodec); ok && ac.ElementType != nil {
-					elemOID := ac.ElementType.OID
-					result := make([]string, len(v.Elements))
-					for i, elem := range v.Elements {
-						if elem == "" {
-							continue
-						}
-						var s string
-						if err := c.typeMap.Scan(elemOID, pgtype.BinaryFormatCode, []byte(elem), &s); err == nil {
-							result[i] = s
-						} else if elemOID == pgtype.MacaddrOID && len(elem) == 6 {
-							// Explicit fallback: decode macaddr binary (6 bytes) to "XX:XX:XX:XX:XX:XX"
-							result[i] = net.HardwareAddr([]byte(elem)).String()
-						} else {
-							result[i] = elem
-						}
-					}
-					return result, nil
-				}
-			}
 			return v.Elements, nil
 		}
 	case []string:

flow/go.mod

@@ -36,7 +36,7 @@ require (
 	github.com/hamba/avro/v2 v2.31.0
 	github.com/jackc/pgerrcode v0.0.0-20250907135507-afb5586c32a6
 	github.com/jackc/pglogrepl v0.0.0-20260401131349-e37c41485510
-	github.com/jackc/pgx/v5 v5.9.2
+	github.com/jackc/pgx/v5 v5.8.0 // PINNED: v5.9.0+ decodes macaddr array elements as raw bytes in binary protocol
 	github.com/joho/godotenv v1.5.1
 	github.com/json-iterator/go v1.1.12
 	github.com/lestrrat-go/httprc/v3 v3.0.5
@@ -311,6 +311,9 @@ replace github.com/PeerDB-io/peerdb/flow/pkg => ./pkg
 
 // Block MVS from raising require minima above the pinned versions in the require block — append new releases here until unpinned.
 exclude (
+	github.com/jackc/pgx/v5 v5.9.0
+	github.com/jackc/pgx/v5 v5.9.1
+	github.com/jackc/pgx/v5 v5.9.2
 	cloud.google.com/go/storage v1.60.0
 	cloud.google.com/go/storage v1.61.0
 	cloud.google.com/go/storage v1.62.0

flow/go.sum

@@ -504,6 +504,8 @@ github.com/jackc/pgpassfile v1.0.0 h1:/6Hmqy13Ss2zCq62VdNG8tM1wchn8zjSGOBJ6icpsI
 github.com/jackc/pgpassfile v1.0.0/go.mod h1:CEx0iS5ambNFdcRtxPj5JhEz+xB6uRky5eyVu/W2HEg=
 github.com/jackc/pgservicefile v0.0.0-20240606120523-5a60cdf6a761 h1:iCEnooe7UlwOQYpKFhBabPMi4aNAfoODPEFNiAnClxo=
 github.com/jackc/pgservicefile v0.0.0-20240606120523-5a60cdf6a761/go.mod h1:5TJZWKEWniPve33vlWYSoGYefn3gLQRzjfDlhSJ9ZKM=
+github.com/jackc/pgx/v5 v5.8.0 h1:TYPDoleBBme0xGSAX3/+NujXXtpZn9HBONkQC7IEZSo=
+github.com/jackc/pgx/v5 v5.8.0/go.mod h1:QVeDInX2m9VyzvNeiCJVjCkNFqzsNb43204HshNSZKw=
 github.com/jackc/pgx/v5 v5.9.1 h1:uwrxJXBnx76nyISkhr33kQLlUqjv7et7b9FjCen/tdc=
 github.com/jackc/pgx/v5 v5.9.1/go.mod h1:mal1tBGAFfLHvZzaYh77YS/eC6IX9OWbRV1QIIM0Jn4=
 github.com/jackc/pgx/v5 v5.9.2 h1:3ZhOzMWnR4yJ+RW1XImIPsD1aNSz4T4fyP7zlQb56hw=

flow/pkg/go.mod

@@ -6,7 +6,7 @@ require (
 	github.com/ClickHouse/ch-go v0.71.0
 	github.com/ClickHouse/clickhouse-go/v2 v2.45.0
 	github.com/go-mysql-org/go-mysql v1.14.0
-	github.com/jackc/pgx/v5 v5.9.2
+	github.com/jackc/pgx/v5 v5.8.0 // PINNED: v5.9.0+ decodes macaddr array elements as raw bytes in binary protocol
 	github.com/stretchr/testify v1.11.1
 	go.mongodb.org/mongo-driver/v2 v2.6.0
 	go.temporal.io/sdk v1.42.0
@@ -64,3 +64,10 @@ require (
 	gopkg.in/natefinch/lumberjack.v2 v2.2.1 // indirect
 	gopkg.in/yaml.v3 v3.0.1 // indirect
 )
+
+// Block MVS from raising require minima above the pinned versions in the require block — append new releases here until unpinned.
+exclude (
+	github.com/jackc/pgx/v5 v5.9.0
+	github.com/jackc/pgx/v5 v5.9.1
+	github.com/jackc/pgx/v5 v5.9.2
+)