Commit e7499e6
fix(mysql): fail fast on partial JSON binlog events
When binlog_row_value_options=PARTIAL_JSON is enabled at runtime on the
source, MySQL emits PARTIAL_UPDATE_ROWS_EVENT carrying JSON diffs instead
of full values. go-mysql parses these as a *RowsEvent, but PeerDB's inner
event-type switch had no case for it and no default, so the entire update
(all columns) was silently dropped after its bytes were counted as
consumed — CDC advanced past it, causing silent data loss.
Add a PARTIAL_UPDATE_ROWS_EVENT case that fails fast with a classified
error (NOTIFY_BINLOG_PARTIAL_JSON_UNSUPPORTED) telling the user to disable
binlog_row_value_options and resync, plus a default branch so any future
rows-event subtype errors loudly instead of dropping data. The JsonDiff
value conversion now errors as a defensive backstop. Scoped to tables in
the pipe via the existing `schema != nil` guard.
Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>1 parent cd189a0 commit e7499e6
5 files changed
Lines changed: 48 additions & 2 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
145 | 145 | | |
146 | 146 | | |
147 | 147 | | |
| 148 | + | |
| 149 | + | |
| 150 | + | |
148 | 151 | | |
149 | 152 | | |
150 | 153 | | |
| |||
1119 | 1122 | | |
1120 | 1123 | | |
1121 | 1124 | | |
| 1125 | + | |
| 1126 | + | |
| 1127 | + | |
| 1128 | + | |
| 1129 | + | |
| 1130 | + | |
| 1131 | + | |
1122 | 1132 | | |
1123 | 1133 | | |
1124 | 1134 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
1243 | 1243 | | |
1244 | 1244 | | |
1245 | 1245 | | |
| 1246 | + | |
| 1247 | + | |
| 1248 | + | |
| 1249 | + | |
| 1250 | + | |
| 1251 | + | |
| 1252 | + | |
| 1253 | + | |
| 1254 | + | |
| 1255 | + | |
| 1256 | + | |
| 1257 | + | |
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
813 | 813 | | |
814 | 814 | | |
815 | 815 | | |
| 816 | + | |
| 817 | + | |
| 818 | + | |
| 819 | + | |
| 820 | + | |
| 821 | + | |
| 822 | + | |
816 | 823 | | |
817 | 824 | | |
818 | 825 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
2 | 2 | | |
3 | 3 | | |
4 | 4 | | |
| 5 | + | |
5 | 6 | | |
6 | 7 | | |
7 | 8 | | |
| |||
547 | 548 | | |
548 | 549 | | |
549 | 550 | | |
550 | | - | |
551 | | - | |
| 551 | + | |
| 552 | + | |
| 553 | + | |
552 | 554 | | |
553 | 555 | | |
554 | 556 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
55 | 55 | | |
56 | 56 | | |
57 | 57 | | |
| 58 | + | |
| 59 | + | |
| 60 | + | |
| 61 | + | |
| 62 | + | |
| 63 | + | |
| 64 | + | |
| 65 | + | |
| 66 | + | |
| 67 | + | |
| 68 | + | |
| 69 | + | |
| 70 | + | |
| 71 | + | |
| 72 | + | |
58 | 73 | | |
59 | 74 | | |
60 | 75 | | |
| |||
0 commit comments