Skip to content

Commit fcc2903

Browse files
committed
Review findings doc: CI log
1 parent 542578d commit fcc2903

1 file changed

Lines changed: 11 additions & 0 deletions

File tree

.claude/plans/qualified-table-identifiers-review-findings.md

Lines changed: 11 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -260,3 +260,14 @@ the fixes above. All actionable items now closed (second pass, same day):
260260
0709374b in a temporary git worktree (`/tmp/peerdb-mb`, since removed) with inputs
261261
identical to TestGenerateMergeStmtGolden; output compared byte-for-byte against the
262262
refactored generator (IDENTICAL) before embedding as the test fixture.
263+
- 2026-06-12: Merged main (#4414 shared-destination/N:1 support) — removal logic and
264+
raw-table cleanup ported to QualifiedTable structs; validation now permits exact
265+
duplicate destinations (N:1) while still rejecting dotted collisions between
266+
different destinations; duplicate-destination e2e rejection cases dropped.
267+
Test_Removal_Shared_Destination passes on the branch locally.
268+
- 2026-06-12: Draft PR #4416 opened. First full CI matrix run caught ONE real failure:
269+
Test_Dynamic_Mirror_Config_Via_Signals asserted the legacy SrcTableIdNameMapping in
270+
workflow state (cleared by entry normalization; missed in the suite conversion —
271+
the PG→PG suite doesn't run on the local dev stack). Fixed to assert
272+
SrcTableIdMapping; verified locally; CI fully green on 542578dd (all matrix legs,
273+
lint, CodeQL, clippy, UI).

0 commit comments

Comments
 (0)