[WIP] introduce direct source to destination type conversion#3007
Closed
jgao54 wants to merge 1 commit into
Closed
[WIP] introduce direct source to destination type conversion#3007jgao54 wants to merge 1 commit into
jgao54 wants to merge 1 commit into
Conversation
945e1dc to
22258f0
Compare
22258f0 to
59dfff7
Compare
Contributor
Author
|
Closing in favor of #3011 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR introduce a direct type conversion from PG to CH. This has the benefit of not exposing qvalue, which ideally is hidden as implementation details inside peerdb.
flow/shared/) for easy import.ToSupportedDestinationTypesForPostgresmethod inflow/shared/clickhouse/type_conversion.goandsupportedDestinationTypesinflow/connectors/clickhouse/type_conversion.goare out-of-sync, resulting destination type conversion getting ignored if that happens. We could add a test to ensure this is in sync as well (open to other ideas).TODO:
fetchAllTypeConversionswith a newfetchTypeConversionsForColumnsendpoint using direct type conversion