Remove content length from upload to enable chunked

djw8605 · bbockelm · commit 2273cc9b6005 · 2023-12-01T07:55:46.000-06:00
Removing the content length from a put changes the upload style from full file upload to a chunked encoded upload. A full file upload causes go to read in the entire file in memory while uploading, chunked does not. **NOTE** chunked uploads only work after xrootd has merged and put into production xrootd/xrootd#2102 Corresponds to htcondor/osdf-client#88
diff --git a/client/handle_http.go b/client/handle_http.go
@@ -727,7 +727,6 @@ func UploadFile(src string, dest *url.URL, token string, namespace namespaces.Na
 		log.Errorln("Error creating request:", err)
 		return 0, err
 	}
-	request.ContentLength = fileInfo.Size()
 	// Set the authorization header
 	request.Header.Set("Authorization", "Bearer "+token)
 	var lastKnownWritten int64

Original file line number	Diff line number	Diff line change
`@@ -727,7 +727,6 @@ func UploadFile(src string, dest *url.URL, token string, namespace namespaces.Na`
`727`	`727`	`log.Errorln("Error creating request:", err)`
`728`	`728`	`return 0, err`
`729`	`729`	`}`
`730`		`- request.ContentLength = fileInfo.Size()`
`731`	`730`	`// Set the authorization header`
`732`	`731`	`request.Header.Set("Authorization", "Bearer "+token)`
`733`	`732`	`var lastKnownWritten int64`