Skip to content

logger not printing metadata so use print instead #333

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Oct 31, 2024
Merged

logger not printing metadata so use print instead #333

merged 2 commits into from
Oct 31, 2024

Conversation

@tien-tong
Copy link
Contributor

@tien-tong tien-tong commented Oct 31, 2024

Closes #332.

Changes proposed in this pull request

cubids print-metadata-fields bids_dir used logger that didn't print metadata to terminal. Replaced with print() instead.

Documentation that should be reviewed

None

@tien-tong tien-tong added the bug Something isn't working label Oct 31, 2024
@tien-tong tien-tong self-assigned this Oct 31, 2024
@tien-tong tien-tong requested a review from tsalo October 31, 2024 14:26
tsalo
tsalo approved these changes Oct 31, 2024
View reviewed changes
Copy link
Member

@tsalo tsalo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@tien-tong tien-tong merged commit c16650b into main Oct 31, 2024
9 checks passed
@tien-tong tien-tong deleted the fix/print_metadata branch October 31, 2024 14:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@tsalo tsalo tsalo approved these changes

Assignees

@tien-tong tien-tong

Labels

bug Something isn't working

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

cubids print-metadata-fields bids_dir doesn't print to terminal

3 participants

@tien-tong @tsalo