-
Notifications
You must be signed in to change notification settings - Fork 13
Add --force-unlock to copy-exemplars and fix path to script in apply
#346
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
tsalo
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'd prefer to figure out what's going wrong with IsFile and PathExists than to replace them with Path. Can you drop those changes but keep the rest?
c31861c to
2c4303c
Compare
|
Hi, |
tsalo
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The changes look good to me. I think you just need to link the associated issues with closes #... so that they close when we merge your PR.
|
@tsalo done! added them in my first message |
|
Perfect. Once CI passes, I'll merge. |
--force-unlock to copy-exemplars and fix path to script in apply
|
@gabridele does this PR close #340? |
|
No, @gabridele dropped that element at my request. |
Hi there,
I’m submitting this pull request to address a few issues I came across while using the library. Before submitting, I ran tests as outlined in the documentation to ensure everything works as expected.
Changes proposed in this pull request
This pull request aims to resolve the following issues:
applyandcopy-exemplarsfunctions can't parse command-line input correctly #340applycommand can't apply changes because shell script can't be found where expected #341copy-exemplarsfunction I would get an error claiming argument--force-unlockis missing #342Documentation that should be reviewed
Based on these changes, no updates to the existing documentation are needed.
Feel free to reach out if you have any questions or need further clarification on my edits!
closes #342
closes #341