Skip to content

Conversation

@tsalo
Copy link
Member

@tsalo tsalo commented Jan 7, 2025

Closes none, but is related to #340.

Changes proposed in this pull request

  • Add tests for _path_exists and _is_file.

@tsalo tsalo added the testing label Jan 7, 2025
@tsalo
Copy link
Member Author

tsalo commented Jan 8, 2025

@tientong98 @mattcieslak could you take a look at this? I'm unable to reproduce #340, so I'm worried I might have missed something in the tests.

Copy link
Contributor

@mattcieslak mattcieslak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a very puzzling problem, maybe some extra detailed errors could help?

@tien-tong tien-tong removed the request for review from mattcieslak January 16, 2025 15:37
@tsalo tsalo merged commit 5e6c713 into PennLINC:main Jan 16, 2025
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants