Skip to content

Conversation

@tsalo
Copy link
Member

@tsalo tsalo commented Jan 15, 2025

Closes #350.

Changes proposed in this pull request

  • Test cubids apply's ability to update IntendedFor field.
  • Create new function to generate internal (bids::) BIDS-URI version of path.
  • Check for BIDS-URI IntendedFors and update them as well.

@tsalo tsalo added the bug Something isn't working label Jan 15, 2025
@mattcieslak mattcieslak requested a review from tien-tong January 15, 2025 20:50
@tien-tong tien-tong marked this pull request as ready for review January 15, 2025 21:05
Copy link
Contributor

@tien-tong tien-tong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good so merging

@tien-tong tien-tong merged commit 51dd6e9 into main Jan 15, 2025
10 checks passed
@tien-tong tien-tong deleted the bids-uris branch January 15, 2025 21:18
(
"relpath_long",
relpath_intendedfor_long,
# XXX: Should not have extra leading zero in run entity, but that's a known bug.
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tracked in #272.

"relpath_cs",
relpath_intendedfor_cs,
# XXX: Should not have extra leading zero in run entity, but that's a known bug.
# XXX: CuBIDS enforces longitudinal dataset, so this fails.
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tracked in #300.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

CUBIDS Apply did not update IntendedFor names

4 participants