Skip to content

Conversation

@gabridele
Copy link
Collaborator

@gabridele gabridele commented Jan 15, 2025

Closes #357

Changes proposed in this pull request

  • underscores in named argument --ignore_nifti_headers were changed to dashes in cli.py parsing function for validate command
  • same as above, updated validate command in workflows.py to use dash-only syntax for --ignore_nifti_headers argument

Documentation that should be reviewed

Copy link
Contributor

@mattcieslak mattcieslak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Excellent, thank you!

@mattcieslak
Copy link
Contributor

@gabridele could you please fill out the PR template and document the parameter you changed?

@gabridele gabridele merged commit e44d7bd into PennLINC:main Jan 15, 2025
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Consistently use dashes in command-line interfaces

2 participants