Skip to content

Conversation

@gabridele
Copy link
Collaborator

Closes #376

Changes proposed in this pull request

  • when user provides --local-validator argument to the cubids validate command, it runs the locally installed bids-validator. For use cases where HPCs don't have internet access
  • added argument to parsing function
  • updated calling of validate function by adding new argument
  • build_validator_call has now if statement to accommodate choice of local validator

Documentation that should be reviewed

  • Section regarding installation and prerequisited
  • Adding sections/'boxes' for internetless use cases (might only apply to cubids validate so far)

@gabridele gabridele marked this pull request as ready for review January 16, 2025 13:54
@tien-tong tien-tong self-requested a review January 16, 2025 15:23
Copy link
Contributor

@tien-tong tien-tong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

add docstrings to the functions you're editing, if they don't have it already, or only had partial infor

Copy link
Contributor

@tien-tong tien-tong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please fix lint issues, you can run black on the script and push your changes until it passes lint test

@tien-tong tien-tong added the enhancement New feature or request label Jan 16, 2025
@gabridele
Copy link
Collaborator Author

Done!

@tien-tong tien-tong merged commit 61fed30 into PennLINC:main Jan 16, 2025
9 checks passed
@tien-tong
Copy link
Contributor

@gabridele can you also add instruction on how to download the new schema validation via deno to the documentation?

@gabridele
Copy link
Collaborator Author

@tientong98 will do, as soon as I'm done with another issue

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add option to use compiled or installed version of BIDS validator when internet is not available

2 participants