discontinue M0 scans from inheriting ASL variant names during cubids apply
#467
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
I'll look into the failing pytest. The linting issue seems to stem from you having different linter settings than the project, so you reformatted the code, but those changes aren't compliant with our coding style. The main thing seems to be that you enforced a line length of 79 characters, but we specify 99 in the pyproject.toml. Can you revert the stylistic changes you made? |
Member
|
test_validator is failing because the test dataset isn't valid. Unfortunately, the actual error message is being cropped so it's not clear what part isn't valid... |
Contributor
Author
|
Superseded by #466 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #465.
Changes proposed in this pull request
Documentation that should be reviewed