-
Notifications
You must be signed in to change notification settings - Fork 13
Add --n-cpus to parallize cubids validate --sequential #476
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
For
|
mattcieslak
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good! In the future it might be nice to break up the function into smaller functions, but as long as tests are passing this is good for now
| # This test verifies the method completes without errors when called | ||
| cubids_instance.datalad_save() | ||
| # Add assertions here | ||
| assert True |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
we will want to write more complex tests here eventually. This is fine for now
Closes #475 and #477.
Changes proposed in this pull request
cubids validate:change
--sequentialto--validation-scope {dataset, subject} (default: dataset)change
--sequential-subjectsto--participant-label--validation-scope subject(cubids/workflows.py)_validate_single_subject()to process one subject per processtest_cli.pyfor validation with--validation-scope subject --n-cpustest_cubids.py(replace comments withassert)Documentation that should be reviewed
docs/example.rst--validation-scope subjectl avoids "RangeError: Invalid string length" on large datasetscubids validate BIDS_Dataset_DataLad v0 --validation-scope subject --n-cpus 4