refactor: ran: modernize -fix ./...

Author: philpennock

internal/engine/getent.go

@@ -5,6 +5,7 @@ import (
 	"bufio"
 	"fmt"
 	"os"
+	"slices"
 	"strings"
 
 	"go.pennock.tech/aifr/pkg/protocol"
@@ -194,13 +195,7 @@ func parseColonFile(path string, mapper fieldMapper, key string) ([]protocol.Get
 		}
 
 		if key != "" {
-			matched := false
-			for _, k := range keys {
-				if k == key {
-					matched = true
-					break
-				}
-			}
+			matched := slices.Contains(keys, key)
 			if !matched {
 				continue
 			}
@@ -268,13 +263,7 @@ func parseServicesFile(path, key, protoFilter string) ([]protocol.GetentEntry, e
 
 		if key != "" && name != key && port != key {
 			// Also check aliases.
-			matched := false
-			for _, a := range parts[2:] {
-				if a == key {
-					matched = true
-					break
-				}
-			}
+			matched := slices.Contains(parts[2:], key)
 			if !matched {
 				continue
 			}
@@ -329,13 +318,7 @@ func parseProtocolsFile(path, key string) ([]protocol.GetentEntry, error) {
 		}
 
 		if key != "" && name != key && number != key {
-			matched := false
-			for _, a := range parts[2:] {
-				if a == key {
-					matched = true
-					break
-				}
-			}
+			matched := slices.Contains(parts[2:], key)
 			if !matched {
 				continue
 			}

internal/engine/gitops.go

@@ -386,7 +386,7 @@ func computeByteDiff(a, b string) (identical bool, bd *protocol.ByteDiff) {
 
 	line := 1
 	col := 1
-	for i := 0; i < n; i++ {
+	for i := range n {
 		if dataA[i] != dataB[i] {
 			return false, &protocol.ByteDiff{
 				Offset: int64(i),

internal/engine/search.go

@@ -186,10 +186,7 @@ func (e *Engine) searchFile(root, path string, re *regexp.Regexp, params SearchP
 
 		// Context lines.
 		if params.Context > 0 {
-			startCtx := lineIdx - params.Context
-			if startCtx < 0 {
-				startCtx = 0
-			}
+			startCtx := max(lineIdx-params.Context, 0)
 			endCtx := lineIdx + params.Context
 			if endCtx >= len(allLines) {
 				endCtx = len(allLines) - 1

internal/engine/search_test.go

@@ -4,6 +4,7 @@ package engine
 import (
 	"os"
 	"path/filepath"
+	"strings"
 	"testing"
 	"time"
 )
@@ -81,11 +82,11 @@ func TestSearchWithContext(t *testing.T) {
 func TestSearchMaxMatches(t *testing.T) {
 	dir := t.TempDir()
 	// Create a file with many matches.
-	content := ""
-	for i := 0; i < 100; i++ {
-		content += "match\n"
+	var content strings.Builder
+	for range 100 {
+		content.WriteString("match\n")
 	}
-	mkTestFile(t, dir, "many.txt", content)
+	mkTestFile(t, dir, "many.txt", content.String())
 	eng := newTestEngine(t, dir)
 
 	resp, err := eng.Search("match", dir, SearchParams{MaxMatches: 5})

internal/engine/sortlimit.go

@@ -95,7 +95,7 @@ func compareVersions(a, b string) int {
 
 	n := min(len(segsA), len(segsB))
 
-	for i := 0; i < n; i++ {
+	for i := range n {
 		sa, sb := segsA[i], segsB[i]
 		// Try numeric comparison first.
 		na, errA := strconv.ParseInt(sa, 10, 64)

internal/engine/sysinfo.go

@@ -6,6 +6,7 @@ import (
 	"net"
 	"os"
 	"runtime"
+	"slices"
 	"time"
 
 	"go.pennock.tech/aifr/pkg/protocol"
@@ -20,12 +21,7 @@ func (p *SysinfoParams) include(section string) bool {
 	if len(p.Sections) == 0 {
 		return true
 	}
-	for _, s := range p.Sections {
-		if s == section {
-			return true
-		}
-	}
-	return false
+	return slices.Contains(p.Sections, section)
 }
 
 // Sysinfo gathers system information for fault diagnosis.