-
Notifications
You must be signed in to change notification settings - Fork 47
Enable warnings as error in Python & C++ layer tests #1098
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
mlxd
wants to merge
11
commits into
main
Choose a base branch
from
tests/warning_as_error
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Hello. You may have forgotten to update the changelog!
|
Closing in favour of #1588 |
Reopening to add support for clang-tidy with WAE |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before submitting
Please complete the following checklist when submitting a PR:
All new functions and code must be clearly commented and documented.
Ensure that code is properly formatted by running
make format
.The latest version of black and
clang-format-14
are used in CI/CD to check formatting.All new features must include a unit test.
Integration and frontend tests should be added to
frontend/test
,Quantum dialect and MLIR tests should be added to
mlir/test
, andRuntime tests should be added to
runtime/tests
.When all the above are checked, delete everything above the dashed
line and fill in the pull request template.
Context: This PR adds a clang-tidy GH Action that runs at a predefined weekly periodicity, with all warnings promoted to errors. In addition, we add promotions to the runtime warning checks to errors by default when running directly from the Makefile.
Description of the Change: As above.
Benefits:
Possible Drawbacks:
Related GitHub Issues: