feat: independent desktop notification toggle (closes #47)

Add desktop_notifications config option and --notifications-on/--notifications-off
CLI flags so users can control popups independently from sounds.

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>

Author: garysheng

README.md

@@ -49,12 +49,14 @@ Need to mute sounds and notifications during a meeting or pairing session? Two o
 Other CLI commands:
 
 ```bash
-peon --pause          # Mute sounds
-peon --resume         # Unmute sounds
-peon --status         # Check if paused or active
-peon --packs          # List available sound packs
-peon --pack <name>    # Switch to a specific pack
-peon --pack           # Cycle to the next pack
+peon --pause              # Mute sounds
+peon --resume             # Unmute sounds
+peon --status             # Check if paused or active
+peon --packs              # List available sound packs
+peon --pack <name>        # Switch to a specific pack
+peon --pack               # Cycle to the next pack
+peon --notifications-on   # Enable desktop notifications
+peon --notifications-off  # Disable desktop notifications
 ```
 
 Tab completion is supported — type `peon --pack <TAB>` to see available pack names.
@@ -82,6 +84,7 @@ The config lives at `$CLAUDE_CONFIG_DIR/hooks/peon-ping/config.json` (default: `
 ```
 
 - **volume**: 0.0–1.0 (quiet enough for the office)
+- **desktop_notifications**: `true`/`false` — toggle desktop notification popups independently from sounds (default: `true`)
 - **categories**: Toggle individual sound types on/off
 - **annoyed_threshold / annoyed_window_seconds**: How many prompts in N seconds triggers the easter egg
 - **pack_rotation**: Array of pack names (e.g. `["peon", "sc_kerrigan", "peasant"]`). Each Claude Code session randomly gets one pack from the list and keeps it for the whole session. Leave empty `[]` to use `active_pack` instead.

VERSION

@@ -1 +1 @@
-1.5.13
+1.5.14

completions.bash

@@ -8,7 +8,7 @@ _peon_completions() {
   prev="${COMP_WORDS[COMP_CWORD-1]}"
 
   # Top-level options
-  opts="--pause --resume --toggle --status --packs --pack --help"
+  opts="--pause --resume --toggle --status --packs --pack --notifications-on --notifications-off --help"
 
   if [ "$prev" = "--pack" ]; then
     # Complete pack names by scanning manifest files

completions.fish

@@ -15,4 +15,6 @@ complete -c peon -l pack -d "Switch active sound pack" -r -a "(
     end
   end
 )"
+complete -c peon -l notifications-on -d "Enable desktop notifications"
+complete -c peon -l notifications-off -d "Disable desktop notifications"
 complete -c peon -l help -d "Show help message"

config.json

@@ -2,6 +2,7 @@
   "active_pack": "peon",
   "volume": 0.5,
   "enabled": true,
+  "desktop_notifications": true,
   "categories": {
     "greeting": true,
     "acknowledge": true,

peon.sh

@@ -282,6 +282,41 @@ case "${1:-}" in
     exit 0 ;;
   --status)
     [ -f "$PAUSED_FILE" ] && echo "peon-ping: paused" || echo "peon-ping: active"
+    python3 -c "
+import json
+try:
+    c = json.load(open('$CONFIG'))
+    dn = c.get('desktop_notifications', True)
+    print('peon-ping: desktop notifications ' + ('on' if dn else 'off'))
+except:
+    print('peon-ping: desktop notifications on')
+"
+    exit 0 ;;
+  --notifications-on)
+    python3 -c "
+import json
+config_path = '$CONFIG'
+try:
+    cfg = json.load(open(config_path))
+except:
+    cfg = {}
+cfg['desktop_notifications'] = True
+json.dump(cfg, open(config_path, 'w'), indent=2)
+print('peon-ping: desktop notifications on')
+"
+    exit 0 ;;
+  --notifications-off)
+    python3 -c "
+import json
+config_path = '$CONFIG'
+try:
+    cfg = json.load(open(config_path))
+except:
+    cfg = {}
+cfg['desktop_notifications'] = False
+json.dump(cfg, open(config_path, 'w'), indent=2)
+print('peon-ping: desktop notifications off')
+"
     exit 0 ;;
   --packs)
     python3 -c "
@@ -364,14 +399,16 @@ print(f'peon-ping: switched to {pack_arg} ({display})')
 Usage: peon <command>
 
 Commands:
-  --pause        Mute sounds
-  --resume       Unmute sounds
-  --toggle       Toggle mute on/off
-  --status       Check if paused or active
-  --packs        List available sound packs
-  --pack <name>  Switch to a specific pack
-  --pack         Cycle to the next pack
-  --help         Show this help
+  --pause              Mute sounds
+  --resume             Unmute sounds
+  --toggle             Toggle mute on/off
+  --status             Check if paused or active
+  --packs              List available sound packs
+  --pack <name>        Switch to a specific pack
+  --pack               Cycle to the next pack
+  --notifications-on   Enable desktop notifications
+  --notifications-off  Disable desktop notifications
+  --help               Show this help
 HELPEOF
     exit 0 ;;
   --*)
@@ -412,6 +449,7 @@ if str(cfg.get('enabled', True)).lower() == 'false':
     sys.exit(0)
 
 volume = cfg.get('volume', 0.5)
+desktop_notif = cfg.get('desktop_notifications', True)
 active_pack = cfg.get('active_pack', 'peon')
 pack_rotation = cfg.get('pack_rotation', [])
 annoyed_threshold = int(cfg.get('annoyed_threshold', 3))
@@ -581,6 +619,7 @@ print('MARKER=' + q(marker))
 print('NOTIFY=' + q(notify))
 print('NOTIFY_COLOR=' + q(notify_color))
 print('MSG=' + q(msg))
+print('DESKTOP_NOTIF=' + ('true' if desktop_notif else 'false'))
 print('SOUND_FILE=' + q(sound_file))
 " <<< "$INPUT" 2>/dev/null)"
 
@@ -641,7 +680,7 @@ if [ -n "$SOUND_FILE" ] && [ -f "$SOUND_FILE" ]; then
 fi
 
 # --- Smart notification: only when terminal is NOT frontmost ---
-if [ -n "$NOTIFY" ] && [ "$PAUSED" != "true" ]; then
+if [ -n "$NOTIFY" ] && [ "$PAUSED" != "true" ] && [ "${DESKTOP_NOTIF:-true}" = "true" ]; then
   if ! terminal_is_focused; then
     send_notification "$MSG" "$TITLE" "${NOTIFY_COLOR:-red}"
   fi

tests/peon.bats

@@ -360,6 +360,47 @@ JSON
   ! afplay_was_called
 }
 
+# ============================================================
+# desktop_notifications config
+# ============================================================
+
+@test "desktop_notifications false suppresses notification but plays sound" {
+  # Set desktop_notifications to false
+  /usr/bin/python3 -c "
+import json
+c = json.load(open('$TEST_DIR/config.json'))
+c['desktop_notifications'] = False
+json.dump(c, open('$TEST_DIR/config.json', 'w'), indent=2)
+"
+  run_peon '{"hook_event_name":"Stop","cwd":"/tmp/myproject","session_id":"s1","permission_mode":"default"}'
+  [ "$PEON_EXIT" -eq 0 ]
+  # Sound should still play even with notifications disabled
+  afplay_was_called
+  # Verify config still has desktop_notifications=false (wasn't reset)
+  val=$(/usr/bin/python3 -c "import json; print(json.load(open('$TEST_DIR/config.json')).get('desktop_notifications', True))")
+  [ "$val" = "False" ]
+}
+
+@test "--notifications-off updates config" {
+  run bash "$PEON_SH" --notifications-off
+  [ "$status" -eq 0 ]
+  [[ "$output" == *"desktop notifications off"* ]]
+  # Verify config was updated
+  val=$(/usr/bin/python3 -c "import json; print(json.load(open('$TEST_DIR/config.json')).get('desktop_notifications', True))")
+  [ "$val" = "False" ]
+}
+
+@test "--notifications-on updates config" {
+  # First turn off
+  bash "$PEON_SH" --notifications-off
+  # Then turn on
+  run bash "$PEON_SH" --notifications-on
+  [ "$status" -eq 0 ]
+  [[ "$output" == *"desktop notifications on"* ]]
+  val=$(/usr/bin/python3 -c "import json; print(json.load(open('$TEST_DIR/config.json')).get('desktop_notifications', True))")
+  [ "$val" = "True" ]
+}
+
 # ============================================================
 # --packs (list packs)
 # ============================================================