fix(#80): When binding constraint not working for dependencies after the first one

The container was losing track of the binding injected into thus the checks after the first one were not pointing to the right binding

Author: PereViader

ManualDi.Async/ManualDi.Async.Tests/TestDiContainerBindingWhen.cs

@@ -6,14 +6,37 @@ namespace ManualDi.Async.Tests;
 
 public class TestDiContainerBindingWhen
 {
-    private record NestedInt(int Value);
+    internal class Special;
+    internal class Child;
+    internal class Root(Child child, Special special);
+    
+    public class NestedInt(int value)
+    {
+        public int Value { get; } = value;
+    }
+    
+    [Test]
+    public async Task TestWhenInjectedIntoNested()
+    {
+        //This test checks that the Binding pointer is not lost
+        //The Root depends on both Child and Special and special is the second dependency
+        //If this succeeds, it means that the Root binding pointer is not lost
+        await using var container = await new DiContainerBindings().Install(b =>
+            {
+                b.Bind<Special>().FromConstructor().When(x => x.InjectedIntoType<Root>());
+                b.Bind<Root>().FromConstructor();
+                b.Bind<Child>().FromConstructor();
+            })
+            .WithFailureDebugReport()
+            .Build(CancellationToken.None);
+    }
 
     [Test]
     public async Task TestWhenInjectedIntoType()
     {
         await using var container = await new DiContainerBindings().Install(b =>
         {
-            b.Bind<NestedInt>().FromMethod(c => new NestedInt(c.Resolve<int>())).DependsOn(d => d.ConstructorDependency<int>());
+            b.Bind<NestedInt>().FromConstructor();
             b.Bind<int>().FromInstance(1).When(x => x.InjectedIntoType<object>());
             b.Bind<int>().FromInstance(2).When(x => x.InjectedIntoType<NestedInt>());
         }).Build(CancellationToken.None);
@@ -27,7 +50,7 @@ public async Task TestWhenInjectedIntoId()
     {
         await using var container = await new DiContainerBindings().Install(b =>
         {
-            b.Bind<NestedInt>().FromMethod(c => new NestedInt(c.Resolve<int>())).DependsOn(d => d.ConstructorDependency<int>()).WithId("2");
+            b.Bind<NestedInt>().FromConstructor().WithId("2");
             b.Bind<int>().FromInstance(1).When(x => x.InjectedIntoId("1"));
             b.Bind<int>().FromInstance(2).When(x => x.InjectedIntoId("2"));
         }).Build(CancellationToken.None);

ManualDi.Async/ManualDi.Async/Container/DiContainer.cs

@@ -190,8 +190,10 @@ public void ConstructorDependency<T>()
             if (binding.BindingWiredState < BindingWiredState.Wired)
             {
                 binding.BindingWiredState = BindingWiredState.Wired;
+                var previousInjectedBinding = injectedBinding;
                 injectedBinding = binding;
                 binding.Dependencies?.Invoke(this);
+                injectedBinding = previousInjectedBinding;
                 bindings.Add(binding);
             }
         }
@@ -212,8 +214,10 @@ public void ConstructorDependency<T>(FilterBindingDelegate filter)
             if (binding.BindingWiredState < BindingWiredState.Wired)
             {
                 binding.BindingWiredState = BindingWiredState.Wired;
+                var previousInjectedBinding = injectedBinding;
                 injectedBinding = binding;
                 binding.Dependencies?.Invoke(this);
+                injectedBinding = previousInjectedBinding;
                 bindings.Add(binding);
             }
         }
@@ -230,8 +234,10 @@ public void NullableConstructorDependency<T>()
             if (binding.BindingWiredState < BindingWiredState.Wired)
             {
                 binding.BindingWiredState = BindingWiredState.Wired;
+                var previousInjectedBinding = injectedBinding;
                 injectedBinding = binding;
                 binding.Dependencies?.Invoke(this);
+                injectedBinding = previousInjectedBinding;
                 bindings.Add(binding);
             }
         }
@@ -248,11 +254,13 @@ public void NullableConstructorDependency<T>(FilterBindingDelegate filter)
             if (binding.BindingWiredState < BindingWiredState.Wired)
             {
                 binding.BindingWiredState = BindingWiredState.Wired;
+                var previousInjectedBinding = injectedBinding;
                 injectedBinding = binding;
                 binding.Dependencies?.Invoke(this);
+                injectedBinding = previousInjectedBinding;
                 bindings.Add(binding);
             }
-        }
+        }   
 
         public void InjectionDependency<T>()
         {
@@ -261,7 +269,7 @@ public void InjectionDependency<T>()
             {
                 if (parentDiContainer is null)
                 {
-                    throw new InvalidOperationException($"Type {typeof(T).FullName} injected into {injectedBinding?.GetType().FullName ?? "null"} is not registered.");
+                    throw new InvalidOperationException($"Type {typeof(T).FullName} injected into {injectedBinding?.ConcreteType.FullName ?? "null"} is not registered.");
                 }
                 parentDiContainer.InjectionDependency<T>();
                 return;