Merge pull request #760 from PermanentOrg/628-enable-lint-rules-part-6

slifty · web-flow · commit 0fb32b121e7e · 2025-10-31T15:32:52.000-04:00
Enable lint rules (Part 6)
diff --git a/eslint.config.mjs b/eslint.config.mjs
@@ -136,21 +136,9 @@ export default typescriptEslint.config([
 
 			'@angular-eslint/prefer-standalone': 'off',
 			'class-methods-use-this': 'off',
-			'no-await-in-loop': 'off',
-			'no-case-declarations': 'off',
 			'no-param-reassign': 'off',
-			'no-promise-executor-return': 'off',
-			'no-prototype-builtins': 'off',
-			'no-restricted-globals': 'off',
-			'no-restricted-properties': 'off',
 			'prefer-arrow/prefer-arrow-functions': 'off',
 			'prefer-destructuring': 'off',
-			'prefer-exponentiation-operator': 'off',
-			'prefer-object-spread': 'off',
-			'prefer-promise-reject-errors': 'off',
-			'prefer-regex-literals': 'off',
-			'prefer-template': 'off',
-			'vars-on-top': 'off',
 		},
 	},
 	{
diff --git a/src/app/archive-settings/manage-metadata/subcomponents/form-create/form-create.component.spec.ts b/src/app/archive-settings/manage-metadata/subcomponents/form-create/form-create.component.spec.ts
@@ -99,7 +99,9 @@ describe('FormCreateComponent', () => {
 		fixture.detectChanges();
 
 		expect(find('input').length).toBe(1);
-		await new Promise((resolve) => setTimeout(resolve, 1));
+		await new Promise<void>((resolve) => {
+			setTimeout(resolve, 1);
+		});
 
 		expect(instance.waiting).toBe(false);
 	});
diff --git a/src/app/archive-settings/manage-metadata/subcomponents/form-create/form-create.component.ts b/src/app/archive-settings/manage-metadata/subcomponents/form-create/form-create.component.ts
@@ -48,7 +48,9 @@ export class FormCreateComponent implements OnInit, OnDestroy {
 			this.newTagName = '';
 		} catch (c) {
 			// Wait for next tick to keep waiting = false in case submit is run multiple times
-			await new Promise((resolve) => setTimeout(resolve));
+			await new Promise<void>((resolve) => {
+				setTimeout(resolve);
+			});
 		} finally {
 			this.waiting = false;
 		}
diff --git a/src/app/core/components/account-settings/account-settings.component.spec.ts b/src/app/core/components/account-settings/account-settings.component.spec.ts
@@ -60,7 +60,9 @@ describe('AccountSettingsComponent', () => {
 
 		try {
 			await instance.onSaveProfileInfo('fullName', 'New Name');
-			await new Promise((r) => setTimeout(r, 0));
+			await new Promise<void>((r) => {
+				setTimeout(r, 0);
+			});
 		} finally {
 			expect(setAccountSpy).toHaveBeenCalled();
 			expect(accountUpdateSpy).toHaveBeenCalled();
@@ -84,7 +86,9 @@ describe('AccountSettingsComponent', () => {
 
 		try {
 			await instance.onSaveProfileInfo('fullName', 'New Name');
-			await new Promise((r) => setTimeout(r, 0));
+			await new Promise<void>((r) => {
+				setTimeout(r, 0);
+			});
 		} finally {
 			expect(setAccountSpy).not.toHaveBeenCalled();
 			expect(accountUpdateSpy).toHaveBeenCalled();
diff --git a/src/app/core/components/billing-settings/billing-settings.component.spec.ts b/src/app/core/components/billing-settings/billing-settings.component.spec.ts
@@ -65,7 +65,9 @@ describe('BillingSettingsComponent', () => {
 
 		try {
 			await instance.onSaveInfo('fullName', 'New Name');
-			await new Promise((r) => setTimeout(r, 0));
+			await new Promise<void>((r) => {
+				setTimeout(r, 0);
+			});
 		} finally {
 			expect(setAccountSpy).toHaveBeenCalled();
 			expect(accountUpdateSpy).toHaveBeenCalled();
@@ -90,7 +92,9 @@ describe('BillingSettingsComponent', () => {
 
 		try {
 			await instance.onSaveInfo('fullName', 'New Name');
-			await new Promise((r) => setTimeout(r, 0));
+			await new Promise<void>((r) => {
+				setTimeout(r, 0);
+			});
 		} finally {
 			expect(setAccountSpy).not.toHaveBeenCalled();
 			expect(accountUpdateSpy).toHaveBeenCalled();
diff --git a/src/app/core/services/edit/edit.service.ts b/src/app/core/services/edit/edit.service.ts
@@ -248,7 +248,7 @@ export class EditService {
 					actionDeferred.resolve();
 					this.openPublishDialog(items[0]);
 					break;
-				case 'share':
+				case 'share': {
 					const response: ShareResponse = await this.api.share.getShareLink(
 						items[0],
 					);
@@ -260,6 +260,7 @@ export class EditService {
 						},
 					});
 					break;
+				}
 				default:
 					actionDeferred.resolve();
 			}
diff --git a/src/app/directive/components/directive-edit/test-utils.ts b/src/app/directive/components/directive-edit/test-utils.ts
@@ -42,9 +42,9 @@ export class MockDirectiveRepo {
 		directive: DirectiveCreateRequest,
 	): Promise<DirectiveData> {
 		if (MockDirectiveRepo.failRequest) {
-			await new Promise((resolve) =>
-				setTimeout(resolve, MockDirectiveRepo.errorDelay),
-			);
+			await new Promise<void>((resolve) => {
+				setTimeout(resolve, MockDirectiveRepo.errorDelay);
+			});
 			throw new Error('Forced Unit Test Error');
 		}
 		if (!MockDirectiveRepo.accountExists) {
@@ -86,9 +86,9 @@ export class MockDirectiveRepo {
 		directive: Partial<DirectiveData>,
 	): Promise<DirectiveData> {
 		if (MockDirectiveRepo.failRequest) {
-			await new Promise((resolve) =>
-				setTimeout(resolve, MockDirectiveRepo.errorDelay),
-			);
+			await new Promise<void>((resolve) => {
+				setTimeout(resolve, MockDirectiveRepo.errorDelay);
+			});
 			throw new Error('Forced Unit Test Error');
 		}
 		if (!MockDirectiveRepo.accountExists) {
diff --git a/src/app/file-browser/components/file-list-item/file-list-item.component.ts b/src/app/file-browser/components/file-list-item/file-list-item.component.ts
@@ -396,7 +396,7 @@ export class FileListItemComponent
 
 		switch (dragEvent.type) {
 			case 'start':
-			case 'end':
+			case 'end': {
 				const start = dragEvent.type === 'start';
 
 				if (this.item.isRecord && dragEvent.targetTypes.includes('record')) {
@@ -412,6 +412,7 @@ export class FileListItemComponent
 				}
 
 				break;
+			}
 		}
 	}
 
diff --git a/src/app/file-browser/components/publish/publish.component.ts b/src/app/file-browser/components/publish/publish.component.ts
@@ -91,7 +91,9 @@ export class PublishComponent {
 					if (latest && latest.displayName === this.sourceItem.displayName) {
 						this.publicItem = latest;
 					} else {
-						await new Promise<void>((r) => setTimeout(() => r(), 1000));
+						await new Promise<void>((r) => {
+							setTimeout(() => r(), 1000);
+						});
 					}
 				}
 
diff --git a/src/app/filesystem/permanent-filesystem.spec.ts b/src/app/filesystem/permanent-filesystem.spec.ts
@@ -69,7 +69,9 @@ describe('Permanent Filesystem (Folder Caching)', () => {
 		// Simulate a backend change happening in another window/tab/client/etc.
 		api.addFolder(new FolderVO({ folderId: 0, displayName: 'Updated Value' }));
 		const folder = await fs.getFolder({ folderId: 0 });
-		await new Promise((resolve) => setTimeout(resolve, 0));
+		await new Promise<void>((resolve) => {
+			setTimeout(resolve, 0);
+		});
 
 		expect(folder.displayName).toBe('Updated Value');
 	});
diff --git a/src/app/onboarding/components/create-new-archive/create-new-archive.component.ts b/src/app/onboarding/components/create-new-archive/create-new-archive.component.ts
@@ -286,11 +286,12 @@ export class CreateNewArchiveComponent implements OnInit {
 
 	private setName(archiveTypeTag: OnboardingTypes): void {
 		switch (archiveTypeTag) {
-			case OnboardingTypes.unsure:
+			case OnboardingTypes.unsure: {
 				const name = this.accountService.getAccount()?.fullName;
 				this.name = name;
 				sessionStorage.setItem('archiveName', name);
 				break;
+			}
 			default:
 				this.name = '';
 				break;
diff --git a/src/app/search/services/search.service.ts b/src/app/search/services/search.service.ts
@@ -51,8 +51,8 @@ export class SearchService {
 	}
 
 	public parseSearchTerm(termString: string): [string, TagVOData[]] {
-		const splitByTerm = new RegExp(/\s(?=(?:[^"]+(["])[^"]+\1)*[^"]*$)/g);
-		const getTagName = new RegExp(/"(.+)"/g);
+		const splitByTerm = /\s(?=(?:[^"]+(["])[^"]+\1)*[^"]*$)/g;
+		const getTagName = /"(.+)"/g;
 		let queryString: string;
 		const parsedTags: TagVOData[] = [];
 
diff --git a/src/app/shared/services/account/account.service.ts b/src/app/shared/services/account/account.service.ts
@@ -589,7 +589,9 @@ export class AccountService {
 				)
 				.toPromise();
 		} catch (err) {
-			return await new Promise((resolve, reject) => reject(err));
+			return await new Promise((resolve, reject) => {
+				reject(err);
+			});
 		}
 	}
 
diff --git a/src/app/shared/services/data/data.service.ts b/src/app/shared/services/data/data.service.ts
@@ -536,7 +536,7 @@ export class DataService {
 			case 'key':
 				switch (selectEvent.key) {
 					case 'up':
-					case 'down':
+					case 'down': {
 						const items = this.currentFolder.ChildItemVOs;
 						const index = this.lastManualclickItem
 							? findIndex(items, this.lastManualclickItem)
@@ -564,6 +564,7 @@ export class DataService {
 							}
 						}
 						break;
+					}
 					case 'a':
 						this.clickItemsBetweenIndicies(
 							0,
diff --git a/src/app/shared/utilities/forms.ts b/src/app/shared/utilities/forms.ts
@@ -75,7 +75,7 @@ export const FORM_ERROR_MESSAGES = {
 export function setFormErrors(form: UntypedFormGroup, errors: any) {
 	if (form.valid) {
 		for (const key in errors) {
-			if (errors.hasOwnProperty(key)) {
+			if (Object.hasOwn(errors, key)) {
 				delete errors[key];
 			}
 		}
diff --git a/src/app/shared/utilities/timeout.ts b/src/app/shared/utilities/timeout.ts
@@ -1,3 +1,5 @@
 export async function timeout(t: number = 0) {
-	return await new Promise((resolve) => setTimeout(resolve, t));
+	return await new Promise<void>((resolve) => {
+		setTimeout(resolve, t);
+	});
 }
diff --git a/src/app/views/components/timeline-view/timeline-util.ts b/src/app/views/components/timeline-view/timeline-util.ts
@@ -250,7 +250,7 @@ export function GroupByTimespan(
 		});
 
 		for (const key in groups) {
-			if (groups.hasOwnProperty(key)) {
+			if (Object.hasOwn(groups, key)) {
 				const groupItems = groups[key];
 				if (groupItems.length < minimumGroupCount) {
 					timelineItems.push(...groupItems.map((i) => new TimelineItem(i)));

Original file line number	Diff line number	Diff line change
`@@ -396,7 +396,7 @@ export class FileListItemComponent`
`396`	`396`
`397`	`397`	`switch (dragEvent.type) {`
`398`	`398`	`case 'start':`
`399`		`- case 'end':`
	`399`	`+ case 'end': {`
`400`	`400`	`const start = dragEvent.type === 'start';`
`401`	`401`
`402`	`402`	`if (this.item.isRecord && dragEvent.targetTypes.includes('record')) {`
`@@ -412,6 +412,7 @@ export class FileListItemComponent`
`412`	`412`	`}`
`413`	`413`
`414`	`414`	`break;`
	`415`	`+ }`
`415`	`416`	`}`
`416`	`417`	`}`
`417`	`418`
Original file line number	Diff line number	Diff line change
`@@ -91,7 +91,9 @@ export class PublishComponent {`
`91`	`91`	`if (latest && latest.displayName === this.sourceItem.displayName) {`
`92`	`92`	`this.publicItem = latest;`
`93`	`93`	`} else {`
`94`		`- await new Promise<void>((r) => setTimeout(() => r(), 1000));`
	`94`	`+ await new Promise<void>((r) => {`
	`95`	`+ setTimeout(() => r(), 1000);`
	`96`	`+ });`
`95`	`97`	`}`
`96`	`98`	`}`
`97`	`99`