Add checks for properties that are mapped from stela to VO

The properties from stela for record(location, files) and for folder
(location, thumbnailUrls, paths) did not have a check for null or
undefined and if those properties are not present for some reason
in the response, an error is generated that will block the whole
flow in the browser.

Issue: PER-10357 Fallback for share token

Author: aasandei-vsp

src/app/shared/services/api/folder.repo.spec.ts

@@ -6,17 +6,11 @@ import { HttpService } from '../http/http.service';
 import { FolderRepo } from './folder.repo';
 
 const emptyResponse = { items: [] };
-// The extra properties irrelevant to this test suite need to be there because
-// there are some checks missing in convertStelaFolderToFolderVO,
-// which will be fixed in the next commit
 const fakeFolderResponse = {
 	items: [
 		{
 			id: 42,
 			name: 'Auth Folder',
-			thumbnailUrls: { 200: 'test' },
-			paths: { names: 'test' },
-			location: { stelaLocation: { id: 13 } },
 		},
 	],
 };

src/app/shared/services/api/folder.repo.ts

@@ -115,17 +115,17 @@ const convertStelaFolderToFolderVO = (stelaFolder: StelaFolder): FolderVO => {
 		imageRatio: stelaFolder.imageRatio,
 		type: stelaFolder.type,
 		thumbStatus: stelaFolder.status,
-		thumbURL200: stelaFolder.thumbnailUrls['200'],
-		thumbURL500: stelaFolder.thumbnailUrls['500'],
-		thumbURL1000: stelaFolder.thumbnailUrls['1000'],
-		thumbURL2000: stelaFolder.thumbnailUrls['2000'],
+		thumbURL200: stelaFolder.thumbnailUrls?.['200'],
+		thumbURL500: stelaFolder.thumbnailUrls?.['500'],
+		thumbURL1000: stelaFolder.thumbnailUrls?.['1000'],
+		thumbURL2000: stelaFolder.thumbnailUrls?.['2000'],
 		thumbDT: stelaFolder.displayTimestamp,
-		thumbnail256: stelaFolder.thumbnailUrls['256'],
-		thumbnail256CloudPath: stelaFolder.thumbnailUrls['256'],
+		thumbnail256: stelaFolder.thumbnailUrls?.['256'],
+		thumbnail256CloudPath: stelaFolder.thumbnailUrls?.['256'],
 		status: stelaFolder.status,
 		publicDT: stelaFolder.publicAt,
 		parentFolderId: stelaFolder.parentFolder?.id,
-		pathAsText: stelaFolder.paths.names,
+		pathAsText: stelaFolder.paths?.names,
 		ParentFolderVOs: [new FolderVO({ folderId: stelaFolder.parentFolder?.id })],
 		ChildFolderVOs: childFolderVOs,
 		RecordVOs: childRecordVOs,

src/app/shared/services/api/record.repo.spec.ts

@@ -46,13 +46,8 @@ describe('RecordRepo', () => {
 	// isolating the record.repo service functionality from other
 	// dependencies would make the tests more reliable
 	it('should use a V2 request to get records by id', fakeAsync(() => {
-		// The extra properties irrelevant to this test suite need to be there because
-		// there are some checks missing in convertStelaRecordToRecordVO, which will be
-		//  fixed in the next commit
 		const fakeRecordVO = {
 			recordId: 5,
-			location: { stelaLocation: { id: 13 } },
-			files: [],
 		} as unknown as RecordVO;
 
 		const recordPromise = repo.get([fakeRecordVO]);

src/app/shared/services/api/record.repo.ts

@@ -158,7 +158,7 @@ export const convertStelaSharetoShareVO = (stelaShare: StelaShare): ShareVO =>
 export const convertStelaLocationToLocnVOData = (
 	stelaLocation: StelaLocation,
 ): LocnVOData =>
-	stelaLocation.id
+	stelaLocation?.id
 		? {
 				...stelaLocation,
 				locnId: Number.parseInt(stelaLocation.id, 10),
@@ -178,7 +178,7 @@ export const convertStelaRecordToRecordVO = (
 		folder_linkId: Number.parseInt(stelaRecord.folderLinkId, 10),
 		folder_linkType: stelaRecord.folderLinkType,
 		LocnVO: convertStelaLocationToLocnVOData(stelaRecord.location),
-		FileVOs: stelaRecord.files.map(convertStelaFileToPermanentFile),
+		FileVOs: stelaRecord.files?.map(convertStelaFileToPermanentFile),
 		createdDT: stelaRecord.createdAt,
 		updatedDT: stelaRecord.updatedAt,
 		locnId: stelaRecord.location?.id || null,