Skip to content

Commit 58f7047

Browse files
EnxDeviankang
authored andcommitted
fix(theming): Fix visual regressions from theming P6 (apache#33898)
# Conflicts: # superset-frontend/cypress-base/cypress/e2e/dashboard/actions.test.js # superset-frontend/src/components/FaveStar/index.tsx # superset-frontend/src/components/MetadataBar/MetadataBar.test.tsx # superset-frontend/src/components/MetadataBar/MetadataBar.tsx # superset-frontend/src/explore/components/controls/TextAreaControl.jsx
1 parent 80b5c26 commit 58f7047

File tree

2 files changed

+2
-7
lines changed

2 files changed

+2
-7
lines changed

superset-frontend/src/dashboard/components/Header/index.jsx

Lines changed: 1 addition & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -26,7 +26,6 @@ import {
2626
FeatureFlag,
2727
t,
2828
getExtensionsRegistry,
29-
useTheme,
3029
} from '@superset-ui/core';
3130
import { Global } from '@emotion/react';
3231
import { shallowEqual, useDispatch, useSelector } from 'react-redux';
@@ -161,7 +160,6 @@ const discardChanges = () => {
161160
};
162161

163162
const Header = () => {
164-
const theme = useTheme();
165163
const dispatch = useDispatch();
166164
const [didNotifyMaxUndoHistoryToast, setDidNotifyMaxUndoHistoryToast] =
167165
useState(false);
@@ -652,10 +650,7 @@ const Header = () => {
652650
data-test="header-save-button"
653651
aria-label={t('Save')}
654652
>
655-
<Icons.SaveOutlined
656-
iconColor={hasUnsavedChanges && theme.colors.primary.light5}
657-
iconSize="m"
658-
/>
653+
<Icons.SaveOutlined iconSize="m" />
659654
{t('Save')}
660655
</Button>
661656
</div>

superset-frontend/src/pages/DatasetList/index.tsx

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -456,7 +456,7 @@ const DatasetList: FunctionComponent<DatasetListProps> = ({
456456
'You must be a dataset owner in order to edit. Please reach out to a dataset owner to request modifications or edit access.',
457457
)
458458
}
459-
placement="bottomRight"
459+
placement="bottom"
460460
>
461461
<span
462462
role="button"

0 commit comments

Comments
 (0)