Commit 2a27c36
chore(deps): bump knip (fixes SvelteKit config detection) (#342)
* chore(deps): bump knip (fixes SvelteKit config detection)
knip 6.17.1 -> 6.29.0 via the dev catalog.
The SK3 fix landed in knip 6.19.0 (webpro-nl/knip#1810, "support new
optional sveltekit config pattern via vite config"), written against
sveltekit@3.0.0-next.4 -- our exact case. The plugin's config list is now
['svelte.config.js', ...viteConfig], so it finds the Kit options that
SvelteKit 3 keeps inside vite.config.ts.
Removed as a result:
- workspaces["apps/grove"].sveltekit.config -- auto-detected now; the
workspace key held nothing else and is gone.
- workspaces["."].entry ["vite.config.ts"] -- knip 6.21.0 detects vite
configs on its own and now reports this as a redundant-entry config
hint, which is fatal under treatConfigHintsAsErrors.
- console's hand-mapped $app/env + $app/server paths, replaced by one
ignoreUnresolved that mirrors what the plugin contributes.
apps/console cannot use the auto-detection. resolveFromAST only takes the
vite-config branch when it statically sees `sveltekit` imported from
@sveltejs/kit/vite, and console configures Kit through
svelte-plugin-composer's kit() wrapper. Without help the plugin
contributes nothing there -- the bare bump reported 125 unused files, 8
unused deps, 16 unresolved $lib imports and 68 unused exports/types. So
console restates the route/hook production entries and the $lib alias
explicitly, with a comment. Rewriting console's real build config or
adding a decoy svelte.config.js to satisfy the linter were both rejected.
Also drops 5 dead type re-exports the newer knip detects: four in
data/cost.ts and TerminalTarget in server/api/console-api.ts. Every
consumer imports those from the originating module, not the barrel.
Verified: lint:knip, lint:knip:prod, check, test (264), manypkg,
typesync:check and a frozen-lockfile install all pass. Canary unused
files/exports in both console and grove are still reported, confirming
the clean run reflects a live graph rather than an empty one.
Co-Authored-By: Opus <noreply@anthropic.com>
* chore(deps): update knip to 6.31
Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01Jwe5UwSrJX5HQkjSskfWYv
* chore: drop decisions file + dedupe lockfile
Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01Jwe5UwSrJX5HQkjSskfWYv
* refactor(console): drop svelte-plugin-composer for native SvelteKit wiring
Configure the console app’s Vite plugins directly instead of through
svelte-plugin-composer: spread effect() (svelte-effect-runtime) and ts(true)
(svelte-global-typescript) ahead of a directly-called sveltekit(), which now
carries adapter/kit/compilerOptions inline (this SvelteKit build no longer reads
svelte.config.js). knip’s SvelteKit plugin can now statically see the sveltekit()
call, so the console workspace drops the manual $lib/$app/route-hook stand-ins
and mirrors apps/grove.
Verified: console build green with identical SER transform output (18 .remote.js
server chunks, zero ServerOnlyImportError, effect_remote_ client wrapper),
svelte-check at parity (31 pre-existing errors, unchanged), knip + knip --strict
green, lockfile deduped.
Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01Jwe5UwSrJX5HQkjSskfWYv
---------
Co-authored-by: Janet <janet@petalcat.dev>
Co-authored-by: Opus <noreply@anthropic.com>
Co-authored-by: returnsvoidjanet <returnsvoidjanet@users.noreply.github.com>1 parent 57501b1 commit 2a27c36
7 files changed
Lines changed: 260 additions & 302 deletions
File tree
- apps/console
- src/lib
- data
- server/api
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
56 | 56 | | |
57 | 57 | | |
58 | 58 | | |
59 | | - | |
60 | 59 | | |
61 | 60 | | |
62 | 61 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
6 | 6 | | |
7 | 7 | | |
8 | 8 | | |
9 | | - | |
10 | | - | |
11 | | - | |
12 | | - | |
13 | | - | |
14 | | - | |
15 | | - | |
16 | | - | |
17 | | - | |
| 9 | + | |
18 | 10 | | |
19 | 11 | | |
20 | 12 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
98 | 98 | | |
99 | 99 | | |
100 | 100 | | |
101 | | - | |
| 101 | + | |
102 | 102 | | |
103 | 103 | | |
104 | 104 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
1 | 1 | | |
2 | 2 | | |
3 | 3 | | |
| 4 | + | |
4 | 5 | | |
5 | 6 | | |
6 | 7 | | |
7 | 8 | | |
8 | | - | |
9 | 9 | | |
10 | 10 | | |
11 | 11 | | |
| |||
28 | 28 | | |
29 | 29 | | |
30 | 30 | | |
31 | | - | |
32 | | - | |
33 | | - | |
34 | | - | |
35 | | - | |
36 | | - | |
37 | | - | |
38 | | - | |
39 | | - | |
40 | | - | |
41 | | - | |
42 | | - | |
43 | | - | |
44 | | - | |
| 31 | + | |
| 32 | + | |
| 33 | + | |
| 34 | + | |
| 35 | + | |
| 36 | + | |
| 37 | + | |
| 38 | + | |
| 39 | + | |
| 40 | + | |
| 41 | + | |
| 42 | + | |
| 43 | + | |
| 44 | + | |
45 | 45 | | |
46 | 46 | | |
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
6 | 6 | | |
7 | 7 | | |
8 | 8 | | |
9 | | - | |
10 | | - | |
11 | | - | |
12 | 9 | | |
13 | 10 | | |
14 | 11 | | |
| |||
17 | 14 | | |
18 | 15 | | |
19 | 16 | | |
20 | | - | |
21 | | - | |
22 | | - | |
23 | | - | |
24 | | - | |
25 | | - | |
26 | | - | |
27 | 17 | | |
28 | 18 | | |
29 | 19 | | |
| |||
36 | 26 | | |
37 | 27 | | |
38 | 28 | | |
39 | | - | |
40 | | - | |
41 | | - | |
42 | 29 | | |
43 | 30 | | |
44 | 31 | | |
| |||
0 commit comments