Conversation
Flat package `phala` with functional options client, covering all non-on-chain-KMS API surface: - Auth, CVMs (CRUD + lifecycle + patch), compose/config management - KMS, SSH keys, workspaces, apps, nodes, instance types, OS images - SSE streaming (WatchCVMState), retry with exponential backoff - CVM ID resolution (int, UUID, app_id, hashed, name) - X25519+AES-GCM env encryption for UpdateCVMEnvs/PatchCVM - Full E2E test suite (go:build e2e) matching Python SDK coverage
Avoid unnecessary sleep (up to 20s) when the last retry fails and no more attempts will be made.
- Fix default base URL to https://cloud-api.phala.com/api/v1 - Make RestartCVM force parameter configurable (default false) - Add overwrite/dry_run options to RefreshCVMInstanceID - Add full filtering options to RefreshCVMInstanceIDs
- Move e2e_test.go to e2e/ subdirectory with its own go.mod - Use external package import pattern for cleaner separation - Add comprehensive README.md with usage examples
- Add unit tests for client, errors, helpers, and retry logic - Fix gofmt formatting in source and test files - Add Go pre-commit hooks (gofmt, go vet, go test) to sdks config
Module path: github.com/Phala-Network/phala-cloud/sdks/go Release tag format: sdks/go/v0.x.x
- Rename release-command.yml → release-npm.yml (JS & CLI) - Add release-go.yml for Go SDK releases via `!release go <type>` - Add bump-go-version.sh for semver version bumping - Each workflow silently skips packages it doesn't own - Go releases use git tag `sdks/go/vX.Y.Z` for Go module proxy
MaxRetries was an int defaulting to 0, causing no retries on failure. Changed to *int where nil means unlimited retries, matching JS/Python.
Collaborator
Author
|
!release go patch |
Contributor
|
Expected format: Examples:
|
pacoyang
approved these changes
Mar 18, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
sdks/go/package (phala) — flat package, functional options clientWatchCVMState), retry with exponential backoff (409/429/503)UpdateCVMEnvs/PatchCVMgo:build e2e) matching Python SDK coverage — all 17 subtests passTest plan
go build ./...— compiles cleango vet ./...— no issuesgo test -tags e2e -v -count=1 -timeout 30m ./...— all pass (~17min)