tests: add partial fixtures and extend page-level tests; fix rules to avoid false positives (ignore hidden inputs, page-level detection)

PhilDaiguille · PhilDaiguille · commit 5ff21909f87e · 2026-04-27T12:17:01.000+02:00
diff --git a/AGENTS.md b/AGENTS.md
diff --git a/src/Rules/Forms/InputLabelRule.php b/src/Rules/Forms/InputLabelRule.php
@@ -31,6 +31,11 @@ public function evaluate(Tokens $tokens, int $tokenIndex, callable $emit): void
             return;
         }
 
+        // Ignore hidden inputs: they don't require accessible labels
+        if (preg_match('/\btype\s*=\s*["\']hidden["\']/i', $opening)) {
+            return;
+        }
+
         // Id present?
         $id = null;
         if (preg_match('/\bid\s*=\s*(?:"|\')([^"\']+)(?:"|\')/i', $opening, $m)) {
diff --git a/src/Rules/Structure/LandmarkRule.php b/src/Rules/Structure/LandmarkRule.php
@@ -25,17 +25,26 @@ public function evaluate(Tokens $tokens, int $tokenIndex, callable $emit): void
             return;
         }
 
-        // If we encounter the end of head/body start, and haven't seen
-        // a main landmark previously, emit a missing landmark warning.
-        if (str_contains($value, '<body') || str_contains($value, '</head>')) {
-            // Simple approach: scan a small window ahead to see if a main is present
-            $look = $this->collectUntil($tokenIndex, $tokens, '<main', 200);
-            if (!str_contains($look, '<main') && !preg_match('/role\s*=\s*["\']main["\']/i', $look)) {
-                // Emit at the start of the file for consistency with other
-                // page-level rules (tests expect line 1:1 identifiers).
-                $first = $tokens->get(0);
-                $emit('Page should include a main landmark', $first, 'Landmark.MissingMain');
-            }
+        // This rule is page-level. Only evaluate once per file (at tokenIndex 0)
+        // and only if the content looks like a full HTML page (contains
+        // a <body> or a <!DOCTYPE). This avoids flagging fragments/partials.
+        if (0 !== $tokenIndex) {
+            return;
+        }
+
+        $full = $this->getFullContent($tokens);
+
+        // If this looks like a fragment (no body/doctype), skip evaluation
+        if (!str_contains($full, '<body') && !str_contains(strtoupper($full), '<!DOCTYPE')) {
+            return;
         }
+
+        // Scan the full content for a main landmark or role="main"
+        if (str_contains($full, '<main') || preg_match('/role\s*=\s*["\']main["\']/i', $full)) {
+            return;
+        }
+
+        $first = $tokens->get(0);
+        $emit('Page should include a main landmark', $first, 'Landmark.MissingMain');
     }
 }
diff --git a/src/Rules/Structure/SkipLinkRule.php b/src/Rules/Structure/SkipLinkRule.php
@@ -18,20 +18,24 @@ public function evaluate(Tokens $tokens, int $tokenIndex, callable $emit): void
             return;
         }
 
-        // Only perform a single page-level scan (when invoked on the first
-        // token) to detect absence of skip links. This avoids emitting the
-        // same violation multiple times.
+        // Page-level rule: only run once (tokenIndex 0) and only for full
+        // pages (containing <body> or <!DOCTYPE). This avoids reporting on
+        // partials/components.
         if (0 !== $tokenIndex) {
             return;
         }
 
         $content = $this->getFullContent($tokens);
 
-        if (preg_match('/href\s*=\s*["\"]#([^"\']+)["\"][^>]*>.*?skip/i', $content)) {
+        if (!str_contains($content, '<body') && !str_contains(strtoupper($content), '<!DOCTYPE')) {
             return;
         }
 
-        if (preg_match('/href\s*=\s*["\"]#(main|content)["\"][^>]*>/i', $content)) {
+        if (preg_match('/href\s*=\s*["\']#([^"\']+)["\'][^>]*>.*?skip/i', $content)) {
+            return;
+        }
+
+        if (preg_match('/href\s*=\s*["\']#(main|content)["\'][^>]*>/i', $content)) {
             return;
         }
 
diff --git a/tests/Rules/Forms/Fixtures/valid/input_hidden.html.twig b/tests/Rules/Forms/Fixtures/valid/input_hidden.html.twig
@@ -0,0 +1,5 @@
+<html>
+<body>
+html<input type="hidden" name="token" value="abc">
+</body>
+</html>
diff --git a/tests/Rules/Forms/Fixtures/valid/input_with_aria_variable.html.twig b/tests/Rules/Forms/Fixtures/valid/input_with_aria_variable.html.twig
@@ -0,0 +1,5 @@
+<html>
+<body>
+<input type="text" aria-label="{{ dynamic_label }}">
+</body>
+</html>
diff --git a/tests/Rules/Forms/InputLabelRuleTest.php b/tests/Rules/Forms/InputLabelRuleTest.php
@@ -36,5 +36,11 @@ public static function provideFixtures(): iterable
             __DIR__.'/Fixtures/invalid/input_no_label.html.twig',
             ['InputLabel.InputLabel.MissingLabel:3:1' => 'Input element must have an associated <label> or an aria-label.'],
         ];
+
+        // Hidden inputs should not trigger the rule
+        yield 'input hidden' => [__DIR__.'/Fixtures/valid/input_hidden.html.twig', []];
+
+        // Dynamic aria-label (Twig var) should be considered present
+        yield 'input with aria variable' => [__DIR__.'/Fixtures/valid/input_with_aria_variable.html.twig', []];
     }
 }
diff --git a/tests/Rules/Structure/Fixtures/invalid/duplicate_landmark_trigger.html.twig b/tests/Rules/Structure/Fixtures/invalid/duplicate_landmark_trigger.html.twig
@@ -0,0 +1,9 @@
+<!DOCTYPE html>
+<html>
+<head>
+</head>
+<body>
+<header>Nav</header>
+<div>Content without main</div>
+</body>
+</html>
diff --git a/tests/Rules/Structure/Fixtures/valid/partial_component_fragment.html.twig b/tests/Rules/Structure/Fixtures/valid/partial_component_fragment.html.twig
@@ -0,0 +1,2 @@
+{# partial component - should not be treated as a full page #}
+<div class="card">{{ content }}</div>
diff --git a/tests/Rules/Structure/Fixtures/valid/partial_no_html.html.twig b/tests/Rules/Structure/Fixtures/valid/partial_no_html.html.twig
@@ -0,0 +1,2 @@
+{# partial fragment with no <html> tag - should be valid for page-level rules #}
+<div class="snippet">{{ title }}</div>
diff --git a/tests/Rules/Structure/LandmarkRuleTest.php b/tests/Rules/Structure/LandmarkRuleTest.php
@@ -30,5 +30,13 @@ public static function provideFixtures(): iterable
         yield 'missing main' => [__DIR__.'/Fixtures/invalid/no_main.html.twig', [
             'Landmark.Landmark.MissingMain:1:1' => 'Page should include a main landmark',
         ]];
+
+        // Partials/fragments without <body> should NOT trigger the page-level rule
+        yield 'partial fragment' => [__DIR__.'/Fixtures/valid/partial_component_fragment.html.twig', []];
+
+        // Ensure only one error is emitted when the document has </head><body>
+        yield 'duplicate trigger check' => [__DIR__.'/Fixtures/invalid/duplicate_landmark_trigger.html.twig', [
+            'Landmark.Landmark.MissingMain:1:1' => 'Page should include a main landmark',
+        ]];
     }
 }
diff --git a/tests/Rules/Structure/LangAttributeRuleTest.php b/tests/Rules/Structure/LangAttributeRuleTest.php
@@ -36,5 +36,8 @@ public static function provideFixtures(): iterable
             __DIR__.'/Fixtures/invalid/html_no_lang.html.twig',
             ['LangAttribute.LangAttribute.MissingLang:2:1' => 'The <html> element should have a lang attribute.'],
         ];
+
+        // Partial fragments (no <html>) should not trigger the rule
+        yield 'partial fragment no html' => [__DIR__.'/Fixtures/valid/partial_no_html.html.twig', []];
     }
 }
diff --git a/tests/Rules/Structure/SkipLinkRuleTest.php b/tests/Rules/Structure/SkipLinkRuleTest.php
@@ -27,8 +27,8 @@ public static function provideFixtures(): iterable
 
         yield 'valid main id' => [__DIR__.'/Fixtures/valid/main_id.html.twig', []];
 
-        yield 'missing skip link' => [__DIR__.'/Fixtures/invalid/no_skip_link.html.twig', [
-            'SkipLink.SkipLink.Missing:1:1' => 'Page should include a skip link to bypass navigation',
-        ]];
+        // This fixture is a fragment (no <body> or <!DOCTYPE>); skip link
+        // rule is page-level and should NOT emit on partials.
+        yield 'missing skip link' => [__DIR__.'/Fixtures/invalid/no_skip_link.html.twig', []];
     }
 }

-Original file line number
+Diff line change
@@ @@ -0,0 +1,5 @@ @@
 +<html>
 +<body>
 +html<input type="hidden" name="token" value="abc">
 +</body>
 +</html>
Original file line number	Diff line number	Diff line change
`@@ -36,5 +36,11 @@ public static function provideFixtures(): iterable`
`36`	`36`	`__DIR__.'/Fixtures/invalid/input_no_label.html.twig',`
`37`	`37`	`['InputLabel.InputLabel.MissingLabel:3:1' => 'Input element must have an associated <label> or an aria-label.'],`
`38`	`38`	`];`
	`39`	`+`
	`40`	`+ // Hidden inputs should not trigger the rule`
	`41`	`+ yield 'input hidden' => [__DIR__.'/Fixtures/valid/input_hidden.html.twig', []];`
	`42`	`+`
	`43`	`+ // Dynamic aria-label (Twig var) should be considered present`
	`44`	`+ yield 'input with aria variable' => [__DIR__.'/Fixtures/valid/input_with_aria_variable.html.twig', []];`
`39`	`45`	`}`
`40`	`46`	`}`
Original file line number	Diff line number	Diff line change
`@@ -0,0 +1,2 @@`
	`1`	`+{# partial component - should not be treated as a full page #}`
	`2`	`+<div class="card">{{ content }}</div>`
Original file line number	Diff line number	Diff line change
`@@ -0,0 +1,2 @@`
	`1`	`+{# partial fragment with no <html> tag - should be valid for page-level rules #}`
	`2`	`+<div class="snippet">{{ title }}</div>`