Skip to content

Commit ddf205f

Browse files
committed
Minor bugfix.
1 parent a543bb2 commit ddf205f

File tree

2 files changed

+18
-12
lines changed

2 files changed

+18
-12
lines changed

MPChartExample/src/com/xxmassdeveloper/mpchartexample/CombinedChartActivity.java

+1-1
Original file line numberDiff line numberDiff line change
@@ -48,7 +48,7 @@ protected void onCreate(Bundle savedInstanceState) {
4848

4949
// draw bars behind lines
5050
mChart.setDrawOrder(new DrawOrder[] {
51-
DrawOrder.BAR, DrawOrder.LINE, DrawOrder.CANDLE
51+
DrawOrder.BAR, DrawOrder.LINE
5252
});
5353

5454
YAxis rightAxis = mChart.getAxisRight();

MPChartLib/src/com/github/mikephil/charting/renderer/LineChartRenderer.java

+17-11
Original file line numberDiff line numberDiff line change
@@ -89,6 +89,8 @@ public void drawData(Canvas c) {
8989
}
9090

9191
c.drawBitmap(mPathBitmap, 0, 0, mRenderPaint);
92+
93+
drawCircles(c);
9294
}
9395

9496
protected void drawDataSet(Canvas c, LineDataSet dataSet) {
@@ -269,11 +271,11 @@ protected void drawLinear(Canvas c, LineDataSet dataSet, ArrayList<Entry> entrie
269271
float phaseY = mAnimator.getPhaseY();
270272

271273
mRenderPaint.setStyle(Paint.Style.STROKE);
272-
274+
273275
Canvas canvas = null;
274-
276+
275277
// if the data-set is dashed, draw on bitmap-canvas
276-
if(dataSet.isDashedLineEnabled()) {
278+
if (dataSet.isDashedLineEnabled()) {
277279
canvas = mBitmapCanvas;
278280
} else {
279281
canvas = c;
@@ -324,7 +326,8 @@ protected void drawLinear(Canvas c, LineDataSet dataSet, ArrayList<Entry> entrie
324326
mRenderPaint.setColor(dataSet.getColor());
325327

326328
// c.drawLines(buffer.buffer, mRenderPaint);
327-
canvas.drawLines(buffer.buffer, from, to >= buffer.size() ? buffer.size() - from : range,
329+
canvas.drawLines(buffer.buffer, from, to >= buffer.size() ? buffer.size() - from
330+
: range,
328331
mRenderPaint);
329332
}
330333

@@ -450,11 +453,11 @@ public void drawValues(Canvas c) {
450453

451454
@Override
452455
public void drawExtras(Canvas c) {
453-
drawCircles(c);
456+
454457
}
455458

456459
protected void drawCircles(Canvas c) {
457-
460+
458461
mRenderPaint.setStyle(Paint.Style.FILL);
459462

460463
float phaseX = mAnimator.getPhaseX();
@@ -468,7 +471,7 @@ protected void drawCircles(Canvas c) {
468471

469472
if (!dataSet.isVisible() || !dataSet.isDrawCirclesEnabled())
470473
continue;
471-
474+
472475
mCirclePaintInner.setColor(dataSet.getCircleHoleColor());
473476

474477
Transformer trans = mChart.getTransformer(dataSet.getAxisDependency());
@@ -483,7 +486,7 @@ protected void drawCircles(Canvas c) {
483486
float halfsize = dataSet.getCircleSize() / 2f;
484487

485488
for (int j = 0; j < buffer.size(); j += 2) {
486-
489+
487490
float x = buffer.buffer[j];
488491
float y = buffer.buffer[j + 1];
489492

@@ -494,13 +497,16 @@ protected void drawCircles(Canvas c) {
494497
// bounds
495498
if (!mViewPortHandler.isInBoundsLeft(x) || !mViewPortHandler.isInBoundsY(y))
496499
continue;
497-
498-
mRenderPaint.setColor(dataSet.getCircleColor(j / 2));
500+
501+
int circleColor = dataSet.getCircleColor(j / 2);
502+
503+
mRenderPaint.setColor(circleColor);
499504

500505
c.drawCircle(x, y, dataSet.getCircleSize(),
501506
mRenderPaint);
502507

503-
if (dataSet.isDrawCircleHoleEnabled())
508+
if (dataSet.isDrawCircleHoleEnabled()
509+
&& circleColor != mCirclePaintInner.getColor())
504510
c.drawCircle(x, y,
505511
halfsize,
506512
mCirclePaintInner);

0 commit comments

Comments
 (0)