Skip to content

Commit c9b1195

Browse files
committed
Code cleanups
1 parent c2c4e5f commit c9b1195

File tree

2 files changed

+24
-31
lines changed

2 files changed

+24
-31
lines changed

src/Services/SlideManager.vala

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -47,7 +47,7 @@ public class Spice.SlideManager : Object {
4747
}
4848

4949
public Slide? preview_slide_ = null;
50-
public Slide preview_slide {
50+
public Slide? preview_slide {
5151
get {
5252
if (preview_slide_ == null || preview_slide_.visible == false) {
5353
return null;

src/Widgets/SlideList.vala

Lines changed: 23 additions & 30 deletions
Original file line numberDiff line numberDiff line change
@@ -20,12 +20,12 @@
2020
*/
2121

2222
public class Spice.SlideList : Gtk.Grid {
23-
private Gtk.Grid slides_grid;
23+
public static int WIDTH = 200;
24+
public static int HEIGHT = 150;
25+
2426
private Gtk.ListBox slides_list;
2527
private unowned SlideManager manager;
2628

27-
private Gtk.Button new_slide_button;
28-
2929
public SlideList (SlideManager manager) {
3030
orientation = Gtk.Orientation.VERTICAL;
3131
get_style_context ().add_class ("slide-list");
@@ -87,28 +87,7 @@ public class Spice.SlideList : Gtk.Grid {
8787
});
8888

8989
add (new Gtk.Separator (Gtk.Orientation.HORIZONTAL));
90-
add (slides_toolbar ());
91-
92-
foreach (var slide in manager.slides) {
93-
add_slide (slide);
94-
}
95-
}
96-
97-
private SlideListRow add_slide (Slide slide) {
98-
var slide_row = new SlideListRow (slide, manager);
99-
100-
slide_row.get_style_context ().add_class ("slide");
101-
102-
slides_list.add (slide_row);
103-
slides_list.show_all ();
104-
105-
return slide_row;
106-
}
10790

108-
public static int WIDTH = 200;
109-
public static int HEIGHT = 150;
110-
111-
public Gtk.Button slides_toolbar () {
11291
var plus_icon = new Gtk.Image.from_icon_name ("list-add-symbolic", Gtk.IconSize.LARGE_TOOLBAR);
11392
plus_icon.margin = 3;
11493

@@ -125,7 +104,23 @@ public class Spice.SlideList : Gtk.Grid {
125104
Utils.new_slide (manager);
126105
});
127106

128-
return new_slide_button;
107+
108+
add (new_slide_button);
109+
110+
foreach (var slide in manager.slides) {
111+
add_slide (slide);
112+
}
113+
}
114+
115+
private SlideListRow add_slide (Slide slide) {
116+
var slide_row = new SlideListRow (slide, manager);
117+
118+
slide_row.get_style_context ().add_class ("slide");
119+
120+
slides_list.add (slide_row);
121+
slides_list.show_all ();
122+
123+
return slide_row;
129124
}
130125

131126
private class SlideListRow : Gtk.ListBoxRow {
@@ -141,7 +136,7 @@ public class Spice.SlideList : Gtk.Grid {
141136
slide_widget = new SlideWidget.from_slide (slide);
142137

143138
slide_widget.settings_requested.connect (() => {
144-
popup_menu ();
139+
show_rightclick_menu ();
145140
});
146141

147142
add (slide_widget);
@@ -168,9 +163,7 @@ public class Spice.SlideList : Gtk.Grid {
168163
}
169164
""";
170165

171-
private Gtk.Menu? menu = null;
172-
173-
public void popup_menu () {
166+
public void show_rightclick_menu () {
174167
var menu = new Gtk.Menu ();
175168

176169
var cut = new Gtk.MenuItem.with_label (_("Cut"));
@@ -236,7 +229,7 @@ public class Spice.SlideList : Gtk.Grid {
236229
activate ();
237230

238231
if (event.button == 3) {
239-
popup_menu ();
232+
show_rightclick_menu ();
240233
}
241234

242235
return false;

0 commit comments

Comments
 (0)