Fixed compiler errors from LTO.

Author: Philip Botha

gui.cpp

@@ -302,7 +302,7 @@ static inline void set_hook_tab(int event_index, int action_index, bool changed)
   SendMessage(combo, CB_RESETCONTENT, 0, 0);
 
   const TCHAR *hook_event = hook_event_strings[event_index];
-  TCHAR *hook_action;
+  TCHAR* hook_action{ nullptr };
   int i;
   switch (event_index + first_event) {
     case NSSM_GUI_HOOK_EVENT_ROTATE:

nssm.vcxproj

@@ -22,13 +22,15 @@
     <VCProjectVersion>17.0</VCProjectVersion>
     <ProjectGuid>{32995E05-606F-4D83-A2E6-C2B361B34DF1}</ProjectGuid>
     <RootNamespace>nssm</RootNamespace>
+    <WindowsTargetPlatformVersion>10.0</WindowsTargetPlatformVersion>
   </PropertyGroup>
   <Import Project="$(VCTargetsPath)\Microsoft.Cpp.Default.props" />
   <PropertyGroup Condition="'$(Configuration)|$(Platform)'=='Release|Win32'" Label="Configuration">
     <ConfigurationType>Application</ConfigurationType>
     <PlatformToolset>v143</PlatformToolset>
     <UseOfMfc>false</UseOfMfc>
     <CharacterSet>Unicode</CharacterSet>
+    <WholeProgramOptimization>true</WholeProgramOptimization>
   </PropertyGroup>
   <PropertyGroup Condition="'$(Configuration)|$(Platform)'=='Debug|Win32'" Label="Configuration">
     <ConfigurationType>Application</ConfigurationType>
@@ -129,6 +131,7 @@
       <WarningLevel>Level4</WarningLevel>
       <SuppressStartupBanner>true</SuppressStartupBanner>
       <DebugInformationFormat>ProgramDatabase</DebugInformationFormat>
+      <LanguageStandard_C>stdc17</LanguageStandard_C>
     </ClCompile>
     <ResourceCompile>
       <PreprocessorDefinitions>_DEBUG;%(PreprocessorDefinitions)</PreprocessorDefinitions>
@@ -222,7 +225,10 @@
       <ProgramDataBaseFileName>$(IntDir)</ProgramDataBaseFileName>
       <WarningLevel>Level4</WarningLevel>
       <SuppressStartupBanner>true</SuppressStartupBanner>
-      <DebugInformationFormat>ProgramDatabase</DebugInformationFormat>
+      <DebugInformationFormat>None</DebugInformationFormat>
+      <LanguageStandard_C>stdc17</LanguageStandard_C>
+      <SDLCheck>true</SDLCheck>
+      <MultiProcessorCompilation>true</MultiProcessorCompilation>
     </ClCompile>
     <ResourceCompile>
       <PreprocessorDefinitions>NDEBUG;%(PreprocessorDefinitions)</PreprocessorDefinitions>
@@ -239,6 +245,7 @@
       <RandomizedBaseAddress>false</RandomizedBaseAddress>
       <DataExecutionPrevention />
       <TargetMachine>MachineX86</TargetMachine>
+      <LinkTimeCodeGeneration>UseLinkTimeCodeGeneration</LinkTimeCodeGeneration>
     </Link>
     <Bscmake>
       <SuppressStartupBanner>true</SuppressStartupBanner>

registry.cpp

@@ -1011,7 +1011,7 @@ int get_hook(const TCHAR *service_name, const TCHAR *hook_event, const TCHAR *ho
     log_event(EVENTLOG_ERROR_TYPE, NSSM_EVENT_OUT_OF_MEMORY, _T("hook registry"), _T("get_hook()"), 0);
     return 1;
   }
-  HKEY key;
+  HKEY key{ nullptr };
   long error = open_registry(service_name, registry, KEY_READ, &key, false);
   if (! key) {
     if (error == ERROR_FILE_NOT_FOUND) {

service.cpp

@@ -195,7 +195,7 @@ int affinity_string_to_mask(TCHAR *string, __int64 *mask) {
   list_t set[64];
 
   TCHAR *s = string;
-  TCHAR *end;
+  TCHAR* end{ nullptr };
   int ret;
   int i;
   int n = 0;
@@ -925,7 +925,7 @@ int pre_edit_service(int argc, TCHAR **argv) {
 
   const TCHAR *parameter = 0;
   settings_t *setting = 0;
-  TCHAR *additional;
+  TCHAR* additional{ nullptr };
 
   /* Validate the parameter. */
   if (mandatory > 2) {
@@ -1065,7 +1065,7 @@ int pre_edit_service(int argc, TCHAR **argv) {
     return 0;
   }
 
-  HKEY key;
+  HKEY key{ nullptr };
   value_t value;
   int ret;
 

settings.cpp

@@ -156,7 +156,7 @@ static int setting_dump_string(const TCHAR *service_name, void *param, const TCH
 
 static int setting_set_exit_action(const TCHAR *service_name, void *param, const TCHAR *name, void *default_value, value_t *value, const TCHAR *additional) {
   unsigned long exitcode;
-  TCHAR *code;
+  TCHAR* code{ nullptr };
   TCHAR action_string[ACTION_LEN];
 
   if (additional) {
@@ -758,7 +758,7 @@ static int native_set_dependongroup(const TCHAR *service_name, void *param, cons
   }
 
   /* Update the group list. */
-  TCHAR *groups_buffer;
+  TCHAR* groups_buffer{ nullptr };
   unsigned long groups_buflen;
   if (native_set_dependon(service_name, service_handle, &groups_buffer, &groups_buflen, value, DEPENDENCY_GROUPS)) return -1;
 
@@ -873,7 +873,7 @@ static int native_set_dependonservice(const TCHAR *service_name, void *param, co
   }
 
   /* Update the service list. */
-  TCHAR *services_buffer;
+  TCHAR* services_buffer{ nullptr };
   unsigned long services_buflen;
   if (native_set_dependon(service_name, service_handle, &services_buffer, &services_buflen, value, DEPENDENCY_SERVICES)) return -1;